Fix Boring.rwTap on instance ports #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate. Given FIRRTL now supports this, we can improve this API. Additionally, added a few more D/I + BoringUtils tests
mwachs5
reviewed
Oct 7, 2024
mwachs5
reviewed
Oct 7, 2024
azidar
force-pushed
the
azidar-bugfix-boring-utils-rwtaps-ok-on-ports
branch
from
de958f3 to
b2ecd34
Compare
mwachs5
reviewed
Oct 8, 2024
mwachs5
reviewed
Oct 8, 2024
|
@azidar I changed Milestone to |
|
In fact maybe we shouldn't backport at all since presumably firtool used with |
azidar
force-pushed
the
azidar-bugfix-boring-utils-rwtaps-ok-on-ports
branch
from
7e6ea3c to
a0c16e6
Compare
mwachs5
reviewed
Oct 8, 2024
| )() | ||
| } | ||
|
|
||
| it should "work to tap an Instance[..]'s port" in { |
There was a problem hiding this comment.
this looks good, wondering if you wouldn't want a similar test to the one above where if you tap to a Probe port it should work. But not blocking my review on that
mwachs5
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
could add more test (unless I am missing them) for normal tap to a Probe port should work. And should it fail if you try to rwTap to a Probe Port? tap to a RWProbePort? can add those cases later though as they are sort of unrelated to what you are fixing, i think?
mergify bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Fix Boring.rwTap on instance ports Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate. Given FIRRTL now supports this, we can improve this API. Additionally, added a few more D/I + BoringUtils tests * Added test of rwTap on RWProbe * Testing tap of instance probe port (cherry picked from commit 3bbf860) # Conflicts: # src/main/scala/chisel3/util/experimental/BoringUtils.scala # src/test/scala/chiselTests/BoringUtilsTapSpec.scala
13 tasks
debs-sifive
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Fix Boring.rwTap on instance ports Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate. Given FIRRTL now supports this, we can improve this API. Additionally, added a few more D/I + BoringUtils tests * Added test of rwTap on RWProbe * Testing tap of instance probe port
chiselbot
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Fix Boring.rwTap on instance ports (#4451) * Fix Boring.rwTap on instance ports Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate. Given FIRRTL now supports this, we can improve this API. Additionally, added a few more D/I + BoringUtils tests * Added test of rwTap on RWProbe * Testing tap of instance probe port (cherry picked from commit 3bbf860) # Conflicts: # src/main/scala/chisel3/util/experimental/BoringUtils.scala # src/test/scala/chiselTests/BoringUtilsTapSpec.scala * Resolve backport conflicts --------- Co-authored-by: Adam Izraelevitz <[email protected]> Co-authored-by: Jack Koenig <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior would always put the new probe expression in the instance's module body, but this is incompatible with instances built with Instantiate.
Given FIRRTL now supports this, we can improve this API.
Additionally, added a few more D/I + BoringUtils tests
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
BoringUtils.rwTap can now works on a port of an
instance: Instance[..]Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.