Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry energy through specular reflection, metallic reflection, and transmission. #1514

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Carry energy through specular reflection, metallic reflection, and transmission. #1514

merged 2 commits into from
Dec 27, 2022

Conversation

ThatRedox
Copy link
Member

@ThatRedox ThatRedox commented Dec 11, 2022 •
edited
Loading

Fixes #1512.
Fixes #608.
Fixes #1231.

Test scene reflects emitters off a 100% specular floor:
2022-12-10_17 34 23

Master:
image
PR:
image
Equivalent scene in Blender:
untitled

@JustinTimeCuber
Copy link
Contributor

Also presumably fixes #608 right?

@JustinTimeCuber JustinTimeCuber mentioned this pull request Dec 11, 2022
Merged
@ThatRedox
Copy link
Member Author

ThatRedox commented Dec 11, 2022 •
edited
Loading

Yes.
master:
image

PR:
image

@Peregrine05 Peregrine05 mentioned this pull request Dec 13, 2022
Closed
@Peregrine05
Copy link
Member

This should also close #1231.

IOR: 1 - master:
(emitter underwater)
underwater_ior_1-master
(emitter above water)
above_ior_1-master

IOR: 1 - #1514:
(emitter underwater)
underwater_ior_1-PR_1514
(emitter above water)
above_ior_1-PR_1514

IOR: 1.333 - master:
(emitter underwater)
underwater_ior_1 333-master
(emitter above water)
above_ior_1 333-master

IOR: 1.333 - #1514:
(emitter underwater)
underwater_ior_1 333-PR_1514
(emitter above water)
above_ior_1 333-PR_1514

Camera underwater:
(master)
Emitters test 2-100
(#1514)
Emitters test 2-500
As shown in the final image, #1230 appears to still be an issue.

@leMaik leMaik merged commit c5a013b into chunky-dev:master Dec 27, 2022
@leMaik leMaik added the backport-me A PR that is to be backported to the latest stable Chunky version. label Dec 27, 2022
leMaik pushed a commit that referenced this pull request Dec 28, 2022
@ThatRedox @leMaik
Carry energy through specular reflection, metallic reflection, and tr…
a2e8943 
…ansmission. (#1514)

* Carry energy through specular and metallic reflection and transmission.

* Fix copy/paste typo.
@leMaik leMaik added this to the 2.4.5 milestone Jan 13, 2023
@leMaik leMaik removed the backport-me A PR that is to be backported to the latest stable Chunky version. label Jan 13, 2023
NotStirred pushed a commit to NotStirred/chunky that referenced this pull request Apr 3, 2023
@ThatRedox @NotStirred
Carry energy through specular reflection, metallic reflection, and tr…
25a7065 
…ansmission. (chunky-dev#1514)

* Carry energy through specular and metallic reflection and transmission.

* Fix copy/paste typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug renderer
Projects
None yet
Milestone
2.4.5
4 participants
@ThatRedox @JustinTimeCuber @Peregrine05 @leMaik