hubble: Support --cel-expression filter in hubble observe #32147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
chancez
added
kind/feature
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
Not really sure of the right release note label since we already have #31070 as a release note and this being separate is an artifact of the Hubble CLI repo being merged with cilium. |
|
/test |
kaworu
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kaworu
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Not really sure of the right release note label since we already have #31070 as a release note and this being separate is an artifact of the Hubble CLI repo being merged with cilium.
Sure let's go with release-note/misc for this one then. Requesting change at the patch is currently missing tests.
Signed-off-by: Chance Zibolski <[email protected]>
chancez
force-pushed
the
pr/chancez/hubble_cli_cel_filter
branch
from
e7a3eaf to
bbaa059
Compare
|
@kaworu good catch, tests added. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to cilium/community
that referenced
this pull request
Jul 29, 2024
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to hubble-maintainers team [^3] to recognize and celebrate their tremendous contributions to Hubble subsystem and Cilium observability in general. The proposal is also based on my firm belief that it is advantageous to have more than one maintainer in both European and US time zones. Qualifications [^4]: > Demonstrates a broad knowledge of the project across multiple areas Chance has already been helping hubble-maintainers team by driving Hubble CLI release process, and by improving the dependency management process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to answer Hubble-related questions from the community, and reviewing pull requests and providing insightful feedback to CFPs. Chance has made many critical contributions to Hubble, including adding CEL expression flow filter [^9], and drastically improving the usability of Hubble metrics [^10]. Robin needs no introduction in terms of his contributions to Hubble, but I'm going to do it anyways. Robin is the original author of Hubble multi-node support [^11], which later became known as Hubble Relay. Robin also implemented mTLS for securing communication between Hubble Relay and individual Hubble instances [^12]. Robin is the most active contributor in cilium/hubble repository according to GitHub Insights. Like Chance, Robin has already been helping hubble-maintainers team by handling Hubble CLI releases [^13][^14], and keeping dependencies up to date. > Must be a Cilium committer Both Chance and Robin are Cilium committers. Nomination Process: > Talk to the current maintainers about which part of the project you > would like to help with. I talked to current hubble-maintainers team members regarding my proposal, and I believe both Glib and Sebastian are more than happy to have Chance and Robin to distribute Hubble project maintenance responsibilities. I defer to Glib and Sebastian to either approve this proposal and merge this pull request, or decline it if they feel that they don't need additional maintainers at this point. [^1]: https://github.com/chancez [^2]: https://github.com/rolinh [^3]: https://github.com/orgs/cilium/teams/hubble-maintainers [^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers [^5]: cilium/hubble#1554 [^6]: cilium/hubble#1518 [^7]: cilium/hubble#1413 [^8]: cilium/hubble#1263 [^9]: cilium/cilium#32147 [^10]: cilium/cilium#21079 [^11]: cilium/cilium#11361 [^12]: cilium/cilium#11224 [^13]: cilium/hubble#1253 [^14]: cilium/hubble#1119 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/community
that referenced
this pull request
Jul 29, 2024
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to hubble-maintainers team [^3] to recognize and celebrate their tremendous contributions to Hubble subsystem and Cilium observability in general. The proposal is also based on my firm belief that it is advantageous to have more than one maintainer in both European and US time zones. Qualifications [^4]: > Demonstrates a broad knowledge of the project across multiple areas Chance has already been helping hubble-maintainers team by driving Hubble CLI release process, and by improving the dependency management process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to answer Hubble-related questions from the community, and reviewing pull requests and providing insightful feedback to CFPs. Chance has made many critical contributions to Hubble, including adding CEL expression flow filter [^9], and drastically improving the usability of Hubble metrics [^10]. Robin needs no introduction in terms of his contributions to Hubble, but I'm going to do it anyways. Robin is the original author of Hubble multi-node support [^11], which later became known as Hubble Relay. Robin also implemented mTLS for securing communication between Hubble Relay and individual Hubble instances [^12]. Robin has the most contributions in cilium/hubble repository according to GitHub Insights. Like Chance, Robin has already been helping hubble-maintainers team by handling Hubble CLI releases [^13][^14], and keeping dependencies up to date. > Must be a Cilium committer Both Chance and Robin are Cilium committers. Nomination Process: > Talk to the current maintainers about which part of the project you > would like to help with. I talked to current hubble-maintainers team members regarding my proposal, and I believe both Glib and Sebastian are more than happy to have Chance and Robin to distribute Hubble project maintenance responsibilities. I defer to Glib and Sebastian to either approve this proposal and merge this pull request, or decline it if they feel that they don't need additional maintainers at this point. [^1]: https://github.com/chancez [^2]: https://github.com/rolinh [^3]: https://github.com/orgs/cilium/teams/hubble-maintainers [^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers [^5]: cilium/hubble#1554 [^6]: cilium/hubble#1518 [^7]: cilium/hubble#1413 [^8]: cilium/hubble#1263 [^9]: cilium/cilium#32147 [^10]: cilium/cilium#21079 [^11]: cilium/cilium#11361 [^12]: cilium/cilium#11224 [^13]: cilium/hubble#1253 [^14]: cilium/hubble#1119 Signed-off-by: Michi Mutsuzaki <[email protected]>
glibsm
pushed a commit
to cilium/community
that referenced
this pull request
Aug 6, 2024
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to hubble-maintainers team [^3] to recognize and celebrate their tremendous contributions to Hubble subsystem and Cilium observability in general. The proposal is also based on my firm belief that it is advantageous to have more than one maintainer in both European and US time zones. Qualifications [^4]: > Demonstrates a broad knowledge of the project across multiple areas Chance has already been helping hubble-maintainers team by driving Hubble CLI release process, and by improving the dependency management process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to answer Hubble-related questions from the community, and reviewing pull requests and providing insightful feedback to CFPs. Chance has made many critical contributions to Hubble, including adding CEL expression flow filter [^9], and drastically improving the usability of Hubble metrics [^10]. Robin needs no introduction in terms of his contributions to Hubble, but I'm going to do it anyways. Robin is the original author of Hubble multi-node support [^11], which later became known as Hubble Relay. Robin also implemented mTLS for securing communication between Hubble Relay and individual Hubble instances [^12]. Robin has the most contributions in cilium/hubble repository according to GitHub Insights. Like Chance, Robin has already been helping hubble-maintainers team by handling Hubble CLI releases [^13][^14], and keeping dependencies up to date. > Must be a Cilium committer Both Chance and Robin are Cilium committers. Nomination Process: > Talk to the current maintainers about which part of the project you > would like to help with. I talked to current hubble-maintainers team members regarding my proposal, and I believe both Glib and Sebastian are more than happy to have Chance and Robin to distribute Hubble project maintenance responsibilities. I defer to Glib and Sebastian to either approve this proposal and merge this pull request, or decline it if they feel that they don't need additional maintainers at this point. [^1]: https://github.com/chancez [^2]: https://github.com/rolinh [^3]: https://github.com/orgs/cilium/teams/hubble-maintainers [^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers [^5]: cilium/hubble#1554 [^6]: cilium/hubble#1518 [^7]: cilium/hubble#1413 [^8]: cilium/hubble#1263 [^9]: cilium/cilium#32147 [^10]: cilium/cilium#21079 [^11]: cilium/cilium#11361 [^12]: cilium/cilium#11224 [^13]: cilium/hubble#1253 [^14]: cilium/hubble#1119 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/tetragon
that referenced
this pull request
Nov 10, 2024
Add Common Expression Language [^1] filter in GetEventRequest. See unit tests for sample usages. This is largely based on Hubble CEL expression filter [^2]. [^1]: https://cel.dev/ [^2]: cilium/cilium#32147 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/tetragon
that referenced
this pull request
Nov 12, 2024
Add Common Expression Language [^1] filter in GetEventRequest. See unit tests for sample usages. This is largely based on Hubble CEL expression filter [^2]. [^1]: https://cel.dev/ [^2]: cilium/cilium#32147 Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally opened this PR to the hubble repo cilium/hubble#1465 but now Hubble CLI is part of the cilium repo so I've reopened the PR here.
Implements the CLI side of #31070