Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automerge Renovate minor/patch updates #1263

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Automerge Renovate minor/patch updates #1263

merged 1 commit into from
Oct 20, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Oct 19, 2023 •
edited
Loading

Renovate does a good job, if CI passes, let's auto merge the non-major updates.

@chancez chancez added 🧹 kind/cleanup This includes no functional changes. 🤖 area/CI Impacts the testing / continuous integration testing of the project. labels Oct 19, 2023
@chancez chancez added this to the Hubble CLI 1.0 milestone Oct 19, 2023
@chancez chancez self-assigned this Oct 19, 2023
@chancez chancez requested a review from a team as a code owner October 19, 2023 15:34
@chancez chancez requested review from lambdanis and removed request for a team October 19, 2023 15:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 19, 2023
@chancez chancez requested a review from glibsm October 19, 2023 15:35
rolinh
rolinh approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label Oct 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Oct 19, 2023
glibsm
glibsm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@glibsm glibsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think more might be required here, i'm not sure that renovate bot has access to merge onto main branch, especially without the required number of reviews. But lets see what happens, perhaps I'm wrong

@chancez
Copy link
Contributor Author

chancez commented Oct 20, 2023

@glibsm yeah I agree, it's hard to tell until we try though.

@chancez chancez merged commit 663ec4f into main Oct 20, 2023
5 checks passed
@chancez chancez deleted the pr/chancez/renovate_automerge branch October 20, 2023 15:52
michi-covalent added a commit to cilium/community that referenced this pull request Jul 29, 2024
@michi-covalent
Add chancez and rolinh to hubble-maintainers team
2f0b88c 
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to
hubble-maintainers team [^3] to recognize and celebrate their tremendous
contributions to Hubble subsystem and Cilium observability in general.
The proposal is also based on my firm belief that it is advantageous to
have more than one maintainer in both European and US time zones.

Qualifications [^4]:

> Demonstrates a broad knowledge of the project across multiple areas

Chance has already been helping hubble-maintainers team by driving
Hubble CLI release process, and by improving the dependency management
process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to
answer Hubble-related questions from the community, and reviewing pull
requests and providing insightful feedback to CFPs. Chance has made many
critical contributions to Hubble, including adding CEL expression flow
filter [^9], and drastically improving the usability of Hubble metrics
[^10].

Robin needs no introduction in terms of his contributions to Hubble, but
I'm going to do it anyways. Robin is the original author of Hubble
multi-node support [^11], which later became known as Hubble Relay.
Robin also implemented mTLS for securing communication between Hubble
Relay and individual Hubble instances [^12]. Robin is the most active
contributor in cilium/hubble repository according to GitHub Insights.
Like Chance, Robin has already been helping hubble-maintainers team by
handling Hubble CLI releases [^13][^14], and keeping dependencies up to
date.

> Must be a Cilium committer

Both Chance and Robin are Cilium committers.

Nomination Process:

> Talk to the current maintainers about which part of the project you
> would like to help with.

I talked to current hubble-maintainers team members regarding my
proposal, and I believe both Glib and Sebastian are more than happy to
have Chance and Robin to distribute Hubble project maintenance
responsibilities. I defer to Glib and Sebastian to either approve this
proposal and merge this pull request, or decline it if they feel that
they don't need additional maintainers at this point.

[^1]: https://github.com/chancez
[^2]: https://github.com/rolinh
[^3]: https://github.com/orgs/cilium/teams/hubble-maintainers
[^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers
[^5]: cilium/hubble#1554
[^6]: cilium/hubble#1518
[^7]: cilium/hubble#1413
[^8]: cilium/hubble#1263
[^9]: cilium/cilium#32147
[^10]: cilium/cilium#21079
[^11]: cilium/cilium#11361
[^12]: cilium/cilium#11224
[^13]: cilium/hubble#1253
[^14]: cilium/hubble#1119

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit to cilium/community that referenced this pull request Jul 29, 2024
@michi-covalent
Add chancez and rolinh to hubble-maintainers team
6f3897c 
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to
hubble-maintainers team [^3] to recognize and celebrate their tremendous
contributions to Hubble subsystem and Cilium observability in general.
The proposal is also based on my firm belief that it is advantageous to
have more than one maintainer in both European and US time zones.

Qualifications [^4]:

> Demonstrates a broad knowledge of the project across multiple areas

Chance has already been helping hubble-maintainers team by driving
Hubble CLI release process, and by improving the dependency management
process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to
answer Hubble-related questions from the community, and reviewing pull
requests and providing insightful feedback to CFPs. Chance has made many
critical contributions to Hubble, including adding CEL expression flow
filter [^9], and drastically improving the usability of Hubble metrics
[^10].

Robin needs no introduction in terms of his contributions to Hubble, but
I'm going to do it anyways. Robin is the original author of Hubble
multi-node support [^11], which later became known as Hubble Relay.
Robin also implemented mTLS for securing communication between Hubble
Relay and individual Hubble instances [^12]. Robin has the most
contributions in cilium/hubble repository according to GitHub Insights.
Like Chance, Robin has already been helping hubble-maintainers team by
handling Hubble CLI releases [^13][^14], and keeping dependencies up to
date.

> Must be a Cilium committer

Both Chance and Robin are Cilium committers.

Nomination Process:

> Talk to the current maintainers about which part of the project you
> would like to help with.

I talked to current hubble-maintainers team members regarding my
proposal, and I believe both Glib and Sebastian are more than happy to
have Chance and Robin to distribute Hubble project maintenance
responsibilities. I defer to Glib and Sebastian to either approve this
proposal and merge this pull request, or decline it if they feel that
they don't need additional maintainers at this point.

[^1]: https://github.com/chancez
[^2]: https://github.com/rolinh
[^3]: https://github.com/orgs/cilium/teams/hubble-maintainers
[^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers
[^5]: cilium/hubble#1554
[^6]: cilium/hubble#1518
[^7]: cilium/hubble#1413
[^8]: cilium/hubble#1263
[^9]: cilium/cilium#32147
[^10]: cilium/cilium#21079
[^11]: cilium/cilium#11361
[^12]: cilium/cilium#11224
[^13]: cilium/hubble#1253
[^14]: cilium/hubble#1119

Signed-off-by: Michi Mutsuzaki <[email protected]>
glibsm pushed a commit to cilium/community that referenced this pull request Aug 6, 2024
@michi-covalent @glibsm
Add chancez and rolinh to hubble-maintainers team
a930a0f 
I propose Chance Zibolski [^1] and Robin Hahling [^2] to be added to
hubble-maintainers team [^3] to recognize and celebrate their tremendous
contributions to Hubble subsystem and Cilium observability in general.
The proposal is also based on my firm belief that it is advantageous to
have more than one maintainer in both European and US time zones.

Qualifications [^4]:

> Demonstrates a broad knowledge of the project across multiple areas

Chance has already been helping hubble-maintainers team by driving
Hubble CLI release process, and by improving the dependency management
process [^5][^6][^7][^8]. Chance is very active on Cilium Slack to
answer Hubble-related questions from the community, and reviewing pull
requests and providing insightful feedback to CFPs. Chance has made many
critical contributions to Hubble, including adding CEL expression flow
filter [^9], and drastically improving the usability of Hubble metrics
[^10].

Robin needs no introduction in terms of his contributions to Hubble, but
I'm going to do it anyways. Robin is the original author of Hubble
multi-node support [^11], which later became known as Hubble Relay.
Robin also implemented mTLS for securing communication between Hubble
Relay and individual Hubble instances [^12]. Robin has the most
contributions in cilium/hubble repository according to GitHub Insights.
Like Chance, Robin has already been helping hubble-maintainers team by
handling Hubble CLI releases [^13][^14], and keeping dependencies up to
date.

> Must be a Cilium committer

Both Chance and Robin are Cilium committers.

Nomination Process:

> Talk to the current maintainers about which part of the project you
> would like to help with.

I talked to current hubble-maintainers team members regarding my
proposal, and I believe both Glib and Sebastian are more than happy to
have Chance and Robin to distribute Hubble project maintenance
responsibilities. I defer to Glib and Sebastian to either approve this
proposal and merge this pull request, or decline it if they feel that
they don't need additional maintainers at this point.

[^1]: https://github.com/chancez
[^2]: https://github.com/rolinh
[^3]: https://github.com/orgs/cilium/teams/hubble-maintainers
[^4]: https://github.com/cilium/community/blob/main/CONTRIBUTOR-ROLES.md#maintainers
[^5]: cilium/hubble#1554
[^6]: cilium/hubble#1518
[^7]: cilium/hubble#1413
[^8]: cilium/hubble#1263
[^9]: cilium/cilium#32147
[^10]: cilium/cilium#21079
[^11]: cilium/cilium#11361
[^12]: cilium/cilium#11224
[^13]: cilium/hubble#1253
[^14]: cilium/hubble#1119

Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@glibsm glibsm glibsm approved these changes

@lambdanis lambdanis Awaiting requested review from lambdanis lambdanis is a code owner automatically assigned from cilium/sig-hubble

Assignees

@chancez chancez

Labels
🤖 area/CI Impacts the testing / continuous integration testing of the project. 🧹 kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
Hubble CLI 1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chancez @glibsm @rolinh