-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose updates #9073
Merged
Merged
Docker compose updates #9073
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
86d9d54
start changes to docker compose page
rosieyohannan 81f91e8
add new install command for docker compose in docker non-cimg
rosieyohannan ce8e988
Merge branch 'master' into DOCSS-1621-docker-compose-updates
rosieyohannan 3a0b900
copy edits
rosieyohannan 4124faf
fix docker compose hyphen
rosieyohannan af18a4c
sort out lint fails
rosieyohannan 03d5c99
fix lint error
rosieyohannan d2ebf9c
suggestion from review
rosieyohannan 93503b3
Merge branch 'master' into DOCSS-1621-docker-compose-updates
rosieyohannan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The remote docker daemon runs on a different system than the docker CLI and docker compose
This isn't strictly true now. Remote docker jobs now run on a machine executor, and that is where we spin up the jobs containers. The daemon is running on the same executor. I don't know if this can be reworded somehow to leave out such details 😖 Maybe it doesn't matter for your purposes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I wondered about this - so is the whole explanation of moving data aropund to make it accessible outdated now?
This section is there to point out differences (that users need to be aware of) around using docker compose and the docker executor as an alternative to using docker compose and the machine executor. If this info is now irrelevant I can just remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it does do that. It is perhaps a bit academic. I see the section has only moved as well. So, I'll give this a stamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 i am talking to a prospective customer and they pointed me to this paragraph as a reason for why they couldnt achieve the thing they wanted with remote docker.
i had the same reaction as you @DominicLavery which is that this wording is outdated because remote docker is basically machine now. if i open up a PR to edit the language, any guidance for what to remove Dom? definitley the pieces about "remote engine" and "remote docker daemon runs on a different system". any idea if the person still needs to do the
docker cp
stuff? i would assume no but the user i'm talking to said that it didnt work for them"The issue I was referring to about docker is that as part of the deploy we run a command in a docker container (which has encapsulated some generic infrastructure setup) that requires as input a configuration file accessed via a bind mounted volume. Something like:
docker run -v ./config.yaml:/app/config.yaml ... image
This did not work"
also let me know if you want me to post and tag ask-execution for this question instead. the user did manage to get things working using
docker cp
so maybe that is still needed for some reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE: docker cp
It doesn't really change anything around where the data lives. They still run in a primary docker container and so still might need to copy data around. A volume mount would occur on the hosts file system, not the primary containers so the config file or other data they would be after likely wouldn't be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9170 lmk what you think