Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Which We Fix Our Version Of Tornado To Match Jupyter #35

Merged
merged 1 commit into from
Apr 1, 2019
Merged

In Which We Fix Our Version Of Tornado To Match Jupyter #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [0.4.4] - 2019-03-28

### Fixed
- Fix a version of tornado compatible with our jupyter version (#35)

## [0.4.3] - 2019-02-15

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion civis_jupyter_notebooks/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.4.3'
__version__ = '0.4.4'
3 changes: 3 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ civis~=1.6
requests~=2.18
click~=6.7
notebook~=5.1,!=5.7.*
# for versions of jupyter before 5.7.5 we need to specify tornado<6
# as these older versions of jupyter will break with tornado 6
tornado<6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should upgrade the notebook package to something like notebook>=5.7.5,<6.0.0

I can't remember why we do not want any 5.7 versions ...

If we can successfully upgrade the notebook version to 5.7.x then I think we can also fix the issue with upgrading python3 docker image to use datascience-python 5.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have bandwidth to investigate the impact of changing our jupyter version. I was just trying to fix what we have currently.

six~=1.10
civis-jupyter-extensions~=0.1
GitPython~=2.1