-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed running automated and manual tests written in TS #773
Conversation
While I didn't have any issues running manual tests, I could not figure out how to enable automated tests. Please, take a look at the attached errors:
I've tried to import Would you like to share any tips that might resolve my issues? |
In CKEditor 5 I was using the |
Just to be clear, you just renamed the automated test If so, this is OK that mocha does not work yet. In this PR I wanted to unblock further work but I didn't spend time on the framework (mocha, sinon, etc.). We'll cover this in the future but for now it is enough that the runner considers |
🤔 This PR enables things on the webpack level. Bringing TS support for chai (and sinon, and... other libs) is another thing. But maybe you're right, maybe this PR got too broad at some wildcard. |
Closing in favor of #886. |
Suggested merge commit message (convention)
Feature (tests): Allowed running automated and manual tests written in TS. Closes ckeditor/ckeditor5#11888.