-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for running manual and automated tests written in TS. #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual and automated tests in TypeScript work fine 🎉
Remarks:
-
I found that the build directory for manual tests contains
.ts
files, which are not needed there (they are not imported by.html
files):Would it be possible to not copy TypeScript files?
-
In
lib/tasks/runautomatedtests.js
there isIGNORE_GLOBS
that also should skip TypeScript files. -
I think that a few sentences in the CKE5 docs (contributing section) about the fact that manual and automated tests can be written now in both JavaScript and TypeScript would be useful.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It works as expected, tests are compiled, but we lost type checking due to esbuild. It's fine when prototyping things, tho. I feel that at some point, we will bring back ts-loader
behind some flag.
Suggested merge commit message (convention)
Other (tests): Support for running manual and automated tests written in TypeScript. Remember that test runners do not validate types as we use
esbuild
which ignores it. Closes ckeditor/ckeditor5#14170, ckeditor/ckeditor5#14171.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.