This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/ckeditor5/1517: The editor placeholder configuration using the placeholder attribute should be restricted to <textarea> only
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to set the editor placeholder text (see ckeditor/ckeditor5#1517).
…should be restricted to <textarea> only.
oleq
changed the title
placeholder attribute should be restricted to <textarea> only
Reinmar
reviewed
Feb 11, 2019
|
|
||
| const placeholderText = editor.config.get( 'placeholder' ) || | ||
| editor.sourceElement && editor.sourceElement.getAttribute( 'placeholder' ); | ||
| sourceElement && sourceElement.tagName.toLowerCase() === 'textarea' && sourceElement.getAttribute( 'placeholder' ); |
There was a problem hiding this comment.
Suggested change
| sourceElement && sourceElement.tagName.toLowerCase() === 'textarea' && sourceElement.getAttribute( 'placeholder' ); | |
| sourceElement && sourceElement.tagName === 'TEXTAREA' && sourceElement.getAttribute( 'placeholder' ); |
There was a problem hiding this comment.
To be consistent with the rest of our codebase.
There was a problem hiding this comment.
Or not... we've got both. So I'm leaving this as it is in your PR.
|
BTW, all those changes are internal because they fix something that was introduced in the same iteration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: The editor placeholder configuration using the
placeholderattribute should be restricted to<textarea>only (see ckeditor/ckeditor5#1517).Additional information
Part of ckeditor/ckeditor5#1518.