Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor placeholder should be created from "placeholder" attribute only when source element is <textarea> #1517

Closed
oleq opened this issue Feb 11, 2019 · 3 comments
Closed

Editor placeholder should be created from "placeholder" attribute only when source element is <textarea> #1517

oleq opened this issue Feb 11, 2019 · 3 comments
Assignees
@oleq
Labels
package:editor-balloon package:editor-classic package:editor-decoupled package:editor-inline package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@oleq
Copy link
Member

oleq commented Feb 11, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

master

image

The placeholder attribute is invalid in this case. We must make sure we use a valid HTML.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:engine labels Feb 11, 2019
@oleq oleq added this to the iteration 22 milestone Feb 11, 2019
@oleq oleq self-assigned this Feb 11, 2019
@oleq oleq mentioned this issue Feb 11, 2019
Merged
oleq added a commit that referenced this issue Feb 11, 2019
@oleq
Docs: Because the placeholder attribute is invalid for non–input elem…
0601ec3 
…ents, data-placeholder should be used instead. Closes #1517.
oleq added a commit to ckeditor/ckeditor5-core that referenced this issue Feb 11, 2019
@oleq
Docs: Because the placeholder attribute is invalid for non–input elem…
8092f9a 
…ents, data-placeholder should be used instead (see ckeditor/ckeditor5#1517).
oleq added a commit to ckeditor/ckeditor5-editor-decoupled that referenced this issue Feb 11, 2019
@oleq
Fix: Used the data-placeholder attribute instead of invalid placehold…
46434e3 
…er to set the editor placeholder text (see ckeditor/ckeditor5#1517).
oleq added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Feb 11, 2019
@oleq
Fix: Used the data-placeholder attribute instead of invalid placehold…
2fc5b9b 
…er to set the editor placeholder text (see ckeditor/ckeditor5#1517).
oleq added a commit to ckeditor/ckeditor5-editor-inline that referenced this issue Feb 11, 2019
@oleq
Fix: Used the data-placeholder attribute instead of invalid placehold…
77a7ccc 
…er to set the editor placeholder text (see ckeditor/ckeditor5#1517).
oleq added a commit to ckeditor/ckeditor5-editor-balloon that referenced this issue Feb 11, 2019
@oleq
Fix: Used the data-placeholder attribute instead of invalid placehold…
1ca070e 
…er to set the editor placeholder text (see ckeditor/ckeditor5#1517).
This was referenced Feb 11, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@Reinmar
Copy link
Member

Reinmar commented Feb 11, 2019

I've got second thoughts. If it's named data-placeholder it's not going to work with textarea's placeholder. Do we need support for this attribute at all? Can't we handle this via the config only? And then, only for textareas, from an attribute.

@Reinmar
Copy link
Member

Reinmar commented Feb 11, 2019

:trollface:

#479

and even reading the placeholder from the editor element if the editor was initialised on a textarea.

@oleq
Copy link
Member Author

oleq commented Feb 11, 2019

image

@oleq oleq changed the title Editor placeholder should be created from "data-placeholder" instead of "placeholder" attribute Editor placeholder should be created from "placeholder" attribute only when source element is <textarea> Feb 11, 2019
Reinmar added a commit that referenced this issue Feb 11, 2019
@Reinmar
Merge pull request #1518 from ckeditor/t/1517
c47d835 
Docs: Editor placeholder should be created from the "placeholder" attribute only when the source element is `<textarea>`. Closes #1517.
Reinmar added a commit to ckeditor/ckeditor5-editor-balloon that referenced this issue Feb 11, 2019
@Reinmar
Merge pull request #30 from ckeditor/t/ckeditor5/1517
b4cb299 
Internal: The editor placeholder configuration using the `placeholder` attribute should be restricted to `<textarea>` only (see [ckeditor/ckeditor5#1517](ckeditor/ckeditor5#1517)).
Reinmar added a commit to ckeditor/ckeditor5-editor-decoupled that referenced this issue Feb 11, 2019
@Reinmar
Merge pull request #29 from ckeditor/t/ckeditor5/1517
9067656 
Internal: The editor placeholder configuration using the `placeholder` attribute should be restricted to `<textarea>` only (see [ckeditor/ckeditor5#1517](ckeditor/ckeditor5#1517)).
Reinmar added a commit to ckeditor/ckeditor5-editor-inline that referenced this issue Feb 11, 2019
@Reinmar
Merge pull request #49 from ckeditor/t/ckeditor5/1517
79b5971 
Internal: The editor placeholder configuration using the `placeholder` attribute should be restricted to `<textarea>` only (see [ckeditor/ckeditor5#1517](ckeditor/ckeditor5#1517)).
Reinmar added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Feb 11, 2019
@Reinmar
Merge pull request #84 from ckeditor/t/ckeditor5/1517
7547a23 
Internal: The editor placeholder configuration using the `placeholder` attribute should be restricted to `<textarea>` only (see [ckeditor/ckeditor5#1517](ckeditor/ckeditor5#1517)).
Reinmar added a commit to ckeditor/ckeditor5-core that referenced this issue Feb 12, 2019
@Reinmar
Merge pull request #163 from ckeditor/t/ckeditor5/1517
6095854 
Docs: Editor placeholder should be created from the "placeholder" attribute only when the source element is `<textarea>`. (see [ckeditor/ckeditor5#1517](ckeditor/ckeditor5#1517)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:editor-balloon package:editor-classic package:editor-decoupled package:editor-inline package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

No branches or pull requests
3 participants
@Reinmar @oleq @pomek