This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Integrated multi cell selection with set column /row header commands #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sEnabled properties.
…nabled properties in case of multi-cell selection.
Toggling is not yet supported.
…ies with multiple cell selection.
|
Rebased onto the latest |
|
Just pushed one missing commit, sorry for that 🙈 @ckeditor/qa-team |
~ Conflicts: ~ src/commands/setheadercolumncommand.js ~ src/commands/setheaderrowcommand.js
|
Merged latest master, resolved conflicts. |
|
I'm not sure what is the desired behaviour here, but this cell splitting looks a bit weird: Safari
Chrome:
EDIT:
|
FilipTokarski
approved these changes
Mar 11, 2020
I believe that exactly the same behavior is present on |
~ Conflicts: ~ src/commands/setheadercolumncommand.js
|
Merged the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: Integrated multi cell selection with set column /row header commands. Closes ckeditor/ckeditor5#6127.
Additional information
After this PR the header command state could get a third state - "mixed" because it's possible to make selection where only part of it contains headers:
However to simplify things, I implemented it in a way that command state is true only when all selected cells contain header. Otherwise it's
false.I have based this PR on #266 as this PR adds the API that was useful for this enhancement.Rebased onto master, after #265 added API that I was mocking before.