Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table selection handling: Set heading rows, column commands #6127

Closed
jodator opened this issue Jan 22, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#268
Closed

Table selection handling: Set heading rows, column commands #6127

jodator opened this issue Jan 22, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#268
Assignees
@mlewand
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 30 (v18...

Comments

@jodator
Copy link
Contributor

jodator commented Jan 22, 2020

📝 Provide a description of the improvement

The command should toggle all rows from a selection in the following manner:

  • If the last row (column) from the selected ones is not a header, then extend the heading section to it.
  • If all columns in the selection are heading, remove them from the heading section.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Jan 22, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jan 27, 2020
@Reinmar Reinmar mentioned this issue Jan 31, 2020
Closed
21 tasks
@jodator jodator mentioned this issue Feb 18, 2020
Closed
@jodator jodator modified the milestones: nice-to-have, iteration 30 Feb 21, 2020
@mlewand mlewand self-assigned this Mar 9, 2020
@mlewand mlewand mentioned this issue Mar 10, 2020
Merged
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 11, 2020
@Reinmar
Merge pull request #268 from ckeditor/i/6127
eab1b5f 
Internal: Integrated multi cell selection with set column /row header commands. Closes ckeditor/ckeditor5#6127.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

Integrated multi cell selection with set column /row header commands ckeditor/ckeditor5-table
3 participants
@Reinmar @jodator @mlewand