This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Simplified undo commands due to simplification in engine.model.History. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on ckeditor/ckeditor5-engine#977 |
This was referenced Jun 23, 2017
|
Please resolve conflicts. |
|
API docs need to be updated:
|
…del.History`. Changed: `BaseCommand#_undo` uses `engine.model.Document#transformDeltas` and uses context.
… Added new tests for undo integration.
scofalik
force-pushed
the
ckeditor5-engine/remove-refactor
branch
from
37c68f6 to
9257211
Compare
|
Fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Undo algorithms got simplified thanks to changes in
engine.model:History,RemoveOperation, contextual OT.