This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/38 Make remove on image abortion permanent #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on |
scofalik
commented
Jun 24, 2017
tests/imageuploadengine.js
Outdated
| @@ -234,4 +235,48 @@ describe( 'ImageUploadEngine', () => { | |||
| expect( loader.status ).to.equal( 'aborted' ); | |||
| sinon.assert.calledOnce( abortSpy ); | |||
| } ); | |||
|
|
|||
| it( 'image should be permanently removed if it is removed by user during upload', done => { | |||
There was a problem hiding this comment.
Honestly, I hate this test and how you need to use three consecutive document#event:changesDone to test something "just after the image placeholder is removed".
It's hard to test it because the image is removed in a Promise's catch callback and the Promise is not returned anywhere. This test (and a test above that was already there) are very prone to fail in future because of theoretically unrelated changes.
Anyway, I've spent two hours trying to write this test in a better way and I haven't came up with anything working.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: When image upload is aborted, now the "image placeholder" element is permanently removed so it is not reinserted on undo. Closes ckeditor/ckeditor5#2811.
Additional information
Additionally,
uploadStatusattribute does not change on undo/redo, although this is less important, as image element is in graveyard anyway. Still, this means that there are less deltas created and applied so there are less objects inengine.model.Historyand it is easier to debug.