Skip to content

Commit

Permalink
Merge pull request #9963 from ckeditor/ci/656-html-support
Browse files Browse the repository at this point in the history 
Feature (html-support): Introduced General HTML Support feature. Closes #9970.
  • Loading branch information
@maxbarnas
maxbarnas authored Jun 28, 2021
2 parents 68de1ca + 5932b3c commit a35db85
Show file tree
Hide file tree
Showing 37 changed files with 6,291 additions and 2 deletions.
2 changes: 2 additions & 0 deletions docs/_snippets/features/mathtype.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ ClassicEditor
} )

.then( editor => {
window.editor = editor;

window.attachTourBalloon( {
target: window.findToolbarItem( editor.ui.view.toolbar,
item => item.label && item.label === 'Insert a math equation - MathType' ),
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"@ckeditor/ckeditor5-highlight": "^28.0.0",
"@ckeditor/ckeditor5-horizontal-line": "^28.0.0",
"@ckeditor/ckeditor5-html-embed": "^28.0.0",
"@ckeditor/ckeditor5-html-support": "^28.0.0",
"@ckeditor/ckeditor5-image": "^28.0.0",
"@ckeditor/ckeditor5-indent": "^28.0.0",
"@ckeditor/ckeditor5-language": "^28.0.0",
Expand Down
22 changes: 22 additions & 0 deletions packages/ckeditor5-html-support/docs/_snippets/features/general-html-support.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<div id="snippet-general-html-support">
<h2 data-i18n-context="title">General HTML support</h2>

<div style="color: red; padding: 10px; text-align: center; border: solid 3px red">
<p data-i18n-context="experimental-note">This is an experimental feature.</p>

<details data-i18n-context="experimental-note">
<summary>Read more</summary>

<p>The General HTML support feature is <strong>experimental and not yet production-ready</strong>.</p>
<p>Follow the <a href="https://github.com/ckeditor/ckeditor5/issues/9856">"Stabilize and release a production-ready General HTML support feature"</a> issue for more updates.</p>
</details>
</div>

<p data-i18n-context="description">The <abbr title="General HTML Support">GHS</abbr> feature is enabled in this editor and configured to support the following content (in addition to the content already support by other editor features):</p>

<ul>
<li><code>&lt;div></code>, <code>&lt;details></code>, and <code>&lt;summary></code> elements with all kind of attributes,</li>
<li>paragraphs and headings with <code>data-*</code> attributes and all classes,</li>
<li><code>&lt;span></code> elements with all inline styles and <code>&lt;abbr></code> elements with `title` attributes.</li>
</ul>
</div>
115 changes: 115 additions & 0 deletions packages/ckeditor5-html-support/docs/_snippets/features/general-html-support.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/**
* @license Copyright (c) 2003-2021, CKSource - Frederico Knabben. All rights reserved.
* For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
*/

/* globals console, window, document */

import { CS_CONFIG } from '@ckeditor/ckeditor5-cloud-services/tests/_utils/cloud-services-config.js';

import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset';
import Code from '@ckeditor/ckeditor5-basic-styles/src/code';
import EasyImage from '@ckeditor/ckeditor5-easy-image/src/easyimage';
import ImageUpload from '@ckeditor/ckeditor5-image/src/imageupload';
import CloudServices from '@ckeditor/ckeditor5-cloud-services/src/cloudservices';

import SourceEditing from '@ckeditor/ckeditor5-source-editing/src/sourceediting';
import GeneralHtmlSupport from '@ckeditor/ckeditor5-html-support/src/generalhtmlsupport';

ClassicEditor
.create( document.querySelector( '#snippet-general-html-support' ), {
plugins: [
ArticlePluginSet,
Code,
EasyImage,
ImageUpload,
CloudServices,
SourceEditing,
GeneralHtmlSupport
],
toolbar: {
items: [
'sourceEditing',
'|',
'heading',
'|',
'bold',
'italic',
'code',
'bulletedList',
'numberedList',
'|',
'outdent',
'indent',
'|',
'blockQuote',
'link',
'mediaEmbed',
'insertTable',
'|',
'undo',
'redo'
],
viewportTopOffset: window.getViewportTopOffsetConfig()
},
image: {
toolbar: [
'imageStyle:inline',
'imageStyle:wrapText',
'imageStyle:breakText',
'|',
'toggleImageCaption',
'imageTextAlternative'
]
},
table: {
contentToolbar: [ 'tableColumn', 'tableRow', 'mergeTableCells' ]
},
cloudServices: CS_CONFIG,

htmlSupport: {
allow: [
// Enables <div>, <details>, and <summary> elements with all kind of attributes.
{
name: /^(div|details|summary)$/,
styles: true,
classes: true,
attributes: true
},

// Extends the existing Paragraph and Heading features
// with classes and data-* attributes.
{
name: /^(p|h[2-4])$/,
classes: true,
attributes: /^data-/
},

// Enables <span>s with any inline styles.
{
name: 'span',
styles: true
},

// Enables <abbr>s with the title attribute.
{
name: 'abbr',
attributes: [ 'title' ]
}
]
}
} )
.then( editor => {
window.editor = editor;

window.attachTourBalloon( {
target: window.findToolbarItem( editor.ui.view.toolbar,
item => item.label && item.label === 'Source' ),
text: 'Switch to the source mode to check out the source of the content and play with it.',
editor
} );
} )
.catch( err => {
console.error( err.stack );
} );
239 changes: 239 additions & 0 deletions packages/ckeditor5-html-support/docs/features/general-html-support.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,239 @@
---
category: features
modified_at: 2021-06-13
updated_at: 2021-06-14
---

# General HTML Support

The General HTML Support ("GHS") feature allows developers to easily enable HTML features that are not explicitly supported by any other dedicated CKEditor 5 plugins.

Some examples of HTML features that can be easily enabled using General HTML Support include:

* The `<section>`, `<article>`, and `<div>` elements.
* The `<audio>`, `<video>`, and `<iframe>` elements.
* The `<span>` and `<cite>` elements.
* Some of the attributes on existing dedicated CKEditor 5 features:
* `data-*` and `id` attributes on e.g. `<p>` and `<h1-h6>`,
* `style` and `classes` on e.g. `<strong>` and `<a>`.

The enabled HTML features can be loaded (e.g. via `editor.setData()`), pasted, output (e.g. via `editor.getData()`), and are visible in the editing area. Such content can also be edited in the editor, although, to a limited extent. Read more about it in the [Level of support](#level-of-support) section.

<info-box>
The General HTML Support feature is **experimental and not yet production-ready**.

Follow the ["Stabilize and release a production-ready General HTML Support feature"](https://github.com/ckeditor/ckeditor5/issues/9856) issue for more updates and related issues.
</info-box>

## Demo

The General HTML Support feature is configured via the `config.htmlSupport` property. In it, you need to list the HTML features that should be handled by GHS.

The demo below uses the following configuration:

```js
import SourceEditing from '@ckeditor/ckeditor5-source-editing/src/sourceediting';
import GeneralHtmlSupport from '@ckeditor/ckeditor5-html-support/src/generalhtmlsupport';

ClassicEditor
.create( document.querySelector( '#editor' ), {
plugins: [ SourceEditing, GeneralHtmlSupport, ... ],
toolbar: [ 'sourceEditing', ... ],
htmlSupport: {
allow: {
// Enables <div>, <details>, and <summary> elements with all kind of attributes.
{
name: /^(div|details|summary)$/,
styles: true,
classes: true,
attributes: true
},

// Extends the existing Paragraph and Heading features
// with classes and data-* attributes.
{
name: /^(p|h[2-4])$/,
classes: true,
attributes: /^data-/
},

// Enables <span>s with any inline styles.
{
name: 'span',
styles: true
},

// Enables <abbr>s with the title attribute.
{
name: 'abbr',
attributes: [ 'title' ]
}
}
}
} )
.then( ... )
.catch( ... );
```

{@snippet features/general-html-support}

## Level of support

The difference between specific CKEditor 5 features such as {@link features/basic-styles basic styles} or {@link features/headings headings} and the HTML features enabled by GHS is that a plugin that supports a specific HTML feature provides a complete user experience for that feature, whereas GHS ensures only that such a content is accepted by the editor.

For instance, the dedicated {@link features/basic-styles#available-text-styles bold} feature offers a toolbar button used to make the selected text bold. Together with the {@link features/autoformat autoformatting feature}, it also allows for applying bold style to content by typing a Markdown shortcode (`**foo**`) in the editor. The {@link features/headings headings} feature offers a dropdown from which the user can choose a heading level and ensures that pressing <kbd>Enter</kbd> at the end of a heading creates a new paragraph (and not another heading).

The General HTML Support does not offer any UI for the enabled features and takes only the basic semantics of a given feature into account. If you enable support for `<div>`s via GHS, the user will not be able to create `<div>`s from the editor UI. The GHS will know that a `<div>` is a container element, so it can wrap other blocks (like paragraphs) but cannot be used inline (next to e.g. a `<strong>` element).

Therefore, GHS's main use cases would be:

* Ensuring backwards content compatibility with legacy systems.
* Introducing basic support for missing HTML features at a low cost.

<info-box>
Taken the nature of GHS, you may consider installing the {@link features/source-editing source editing} feature alongside with it.
</info-box>

## Installation

To add this feature to your rich-text editor, install the [`@ckeditor/ckeditor5-html-support`](https://www.npmjs.com/package/@ckeditor/ckeditor5-html-support) package:

```plaintext
npm install --save @ckeditor/ckeditor5-html-support
```

And add it to your plugin list configuration:

```js
import GeneralHtmlSupport from '@ckeditor/ckeditor5-html-support/src/generalhtmlsupport';

ClassicEditor
.create( document.querySelector( '#editor' ), {
plugins: [ GeneralHtmlSupport, ... ],
} )
.then( ... )
.catch( ... );
```

<info-box info>
Read more about {@link builds/guides/integration/installing-plugins installing plugins}.
</info-box>

## Configuration

By default, enabling the {@link module:html-support/generalhtmlsupport~GeneralHtmlSupport} plugin does not enable support for any given element. The elements the user wants to be supported, need to be configured via the {@link module:core/editor/editorconfig~EditorConfig#htmlSupport `config.htmlSupport`} option:

```js
ClassicEditor.create( document.querySelector( '#editor' ), {
htmlSupport: {
allow: [ /* HTML features to allow */ ]
disallow: [ /* HTML features to disallow */ ]
}
} )
```

The notation of the `allow` and `disallow` rules looks as follows:

```js
[
{
// The element name to enable and/or extend with
// the following styles, classes and other attributes.
name: string|regexp,

// Styles to allow (by name, name and value or just all).
styles: object<string=>true|string|regexp>|array<string>|true,

// Classes to allow (by name or just all).
classes: array<string|regexp>|true,

// Other attributes to allow (by name, name and value or just all).
attributes: object<string=>true|string|regexp>|array<string>|true,
}
]
```

Several implementation examples:

```js
htmlSupport: {
allow: [
// Enables plain <div> elements.
{
name: 'div'
},

// Enables plain <div>, <section> and <article> elements.
{
name: /^(div|section|article)$/
},

// Enables <div>s with all inline styles (but no other attributes).
{
name: 'div',
styles: true
},

// Enables <div>s with foo and bar classes.
{
name: 'div',
classes: [ 'foo', 'bar' ]
},

// Adds support for `foo` and `bar` classes to the already supported
// <p> elements (those are enabled by the dedicated paragraph feature).
{
name: 'p',
classes: [ 'foo', 'bar' ]
},

// Enables <div>s with foo="true" attribute and bar attribute that
// can accept any value (boolean `true` value works as an asterisk).
{
name: 'div',
attributes: {
foo: 'true',
bar: true
}
},

// Adds support for style="color: *" to the already supported
// <p> and <h2-h4> elements.
{
name: /^(p|h[2-4])$/',
styles: { 'color': true }
},
}
```
The General HTML Support feature distinguishes several content types, each treated a bit differently:
* Container elements (e.g. `<section>`, `<div>`).
* Inline elements (e.g. `<span>`, `<a>`).
* Object elements (e.g. `<iframe>`, `<video>`).
The enabled elements will not just be available "anywhere" in the content, as they still need to adhere to certain rules derived from the HTML schema and from common sense. Also, the behavior of specific types of elements in the editing area will be different. For instance, the object elements will only be selectable as a whole, and the inline elements will work the same as other formatting features supported by CKEditor 5 (e.g. bold, italic) do.
## Known issues
It is possible to add support for arbitrary styles, classes and other attributes to existing CKEditor 5 features (such as paragraphs, headings, list items, etc.).
Most of the existing CKEditor 5 features can already be extended this way, however, some cannot yet. This includes:
* Some of the table markup [#9914](https://github.com/ckeditor/ckeditor5/issues/9914).
* Some of the image features' markup [#9916](https://github.com/ckeditor/ckeditor5/issues/9916).
* Some of the media embed features' markup [#9918](https://github.com/ckeditor/ckeditor5/issues/9918).
* The `<ul>` and `<ol>` elements of the list feature [#9917](https://github.com/ckeditor/ckeditor5/issues/9917).
We're open for feedback, so if you find any issue, feel free to report it in the [main CKEditor 5 repository](https://github.com/ckeditor/ckeditor5/issues/).

## Related features

There are other HTML editing related CKEditor 5 features you may want to check:

* {@link features/source-editing Source editing} &ndash; Provides the ability for viewing and editing the source of the document.
* {@link features/html-embed HTML embed} &ndash; Allows embedding an arbitrary HTML snippet in the editor. It is a more constrained and controllable approach to arbitrary HTML than GHS.

## Contribute

The source code of the feature is available on GitHub in https://github.com/ckeditor/ckeditor5/tree/master/packages/ckeditor5-html-support.
Loading

0 comments on commit a35db85

Please sign in to comment.