Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHS] Introduce General HTML Support #9963

Merged
merged 218 commits into from
Jun 28, 2021
Merged

[GHS] Introduce General HTML Support #9963

merged 218 commits into from
Jun 28, 2021

Conversation

jacekbogdanski
Copy link
Member

@jacekbogdanski jacekbogdanski commented Jun 28, 2021

Suggested merge commit message (convention)

Feature (html-support): Introduced General HTML Support feature. Closes #9970.


Additional information

Let's see if we can improve anything before the release.

Since most code has been already reviewed, I suppose it doesn't make much sense to do the full review again, but it would be good to check a couple of things to make sure we didn't miss anything during development:

  • manual tests
  • guide
  • API docs
  • overall code quality, rebase artifacts, outdated comments, etc

@jacekbogdanski
Copy link
Member Author

Let's also cover #9951 within this PR.

@maxbarnas maxbarnas self-requested a review June 28, 2021 08:33
Copy link
Contributor

@maxbarnas maxbarnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jacekbogdanski
Copy link
Member Author

Docs update looks good to me 👍🏻

@maxbarnas maxbarnas merged commit a35db85 into master Jun 28, 2021
@maxbarnas maxbarnas deleted the ci/656-html-support branch June 28, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GHS] General HTML Support feature
7 participants