Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check automated and manual tests compatibility with IE11 #329

Closed
maxbarnas opened this issue Sep 15, 2016 · 10 comments
Closed

Check automated and manual tests compatibility with IE11 #329

maxbarnas opened this issue Sep 15, 2016 · 10 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@maxbarnas
Copy link
Contributor

No description provided.

@maxbarnas maxbarnas added type:task This issue reports a chore (non-production change) and other types of "todos". status:inprogress labels Sep 15, 2016
@maxbarnas maxbarnas added this to the iteration 3 milestone Sep 15, 2016
@maxbarnas maxbarnas self-assigned this Sep 15, 2016
@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

What about manual tests? It's worth to check both things in one place.

@maxbarnas
Copy link
Contributor Author

Somehow I thought about manual tests as part of automated procedure. I'll fix the title.

@maxbarnas maxbarnas changed the title Check automated tests compatibility with IE11 Check automated and manual tests compatibility with IE11 Sep 15, 2016
@maxbarnas
Copy link
Contributor Author

maxbarnas commented Sep 15, 2016

Unit tests

229 failed tests, many of which are totally broken (unable to run at all). Errors exist in almost every package. Severity of problems suggests it would take considerably more time than other browsers to make it work.

Manual tests

Unable to run the editor at all. Consecutive tries to init the editor lock the browser.

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

So I guess this is enough for now. It's bad, we know it :D. We can either close this ticket or spend few more minutes on trying to understand what's stopping editor from work at all. In both cases, we also need a ticket for working on IE11 compat in the future.

@maxbarnas
Copy link
Contributor Author

Everything depends on the priority of running CKE5 in IE11. I would postpone it until we have the editor up and running in other browsers. But @fredck might have different opinion and goals.

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

It's not a matter of goals. The goal is pretty clear – we want to understand something now, to know how bad it is. You mentioned that the editor doesn't even start, so I'd be curious if this is something that we can understand in couple of minutes and perhaps even fix to continue the research. Because 200 failed tests may mean that editor is functional, but a bit buggy in some cases, or, absolutely unusable. But right now we don't know this because the editor doesn't even start (which can be a small, unrelated issue).

@maxbarnas
Copy link
Contributor Author

By goals I meant how important is to have IE11 working. Other that that I understand and agree with you.

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

It's pretty important (see discussion in ckeditor/ckeditor5-design#156).

@fredck
Copy link
Contributor

fredck commented Sep 15, 2016

I agree that this is enough for now.

Let's just hope that we just have a few tricky blockers which are breaking most of the code execution. But we gonna handle this in the future.

Thanks for the research @maxbarnas ;)

@oskarwrobel
Copy link
Contributor

oskarwrobel commented Sep 15, 2016

I've just noticed that we are using not supported by IE Event() constructor for dispatching events in tests (it might be helpful in the future).

mlewand pushed a commit that referenced this issue May 1, 2020
Fix: The `getOptimalPosition()` helper should prefer positions that fit inside the viewport even though there are some others that fit better into the limiter. Closes #6181.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants