-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check automated and manual tests compatibility with IE11 #329
Comments
What about manual tests? It's worth to check both things in one place. |
Somehow I thought about manual tests as part of automated procedure. I'll fix the title. |
Unit tests229 failed tests, many of which are totally broken (unable to run at all). Errors exist in almost every package. Severity of problems suggests it would take considerably more time than other browsers to make it work. Manual testsUnable to run the editor at all. Consecutive tries to init the editor lock the browser. |
So I guess this is enough for now. It's bad, we know it :D. We can either close this ticket or spend few more minutes on trying to understand what's stopping editor from work at all. In both cases, we also need a ticket for working on IE11 compat in the future. |
Everything depends on the priority of running CKE5 in IE11. I would postpone it until we have the editor up and running in other browsers. But @fredck might have different opinion and goals. |
It's not a matter of goals. The goal is pretty clear – we want to understand something now, to know how bad it is. You mentioned that the editor doesn't even start, so I'd be curious if this is something that we can understand in couple of minutes and perhaps even fix to continue the research. Because 200 failed tests may mean that editor is functional, but a bit buggy in some cases, or, absolutely unusable. But right now we don't know this because the editor doesn't even start (which can be a small, unrelated issue). |
By goals I meant how important is to have IE11 working. Other that that I understand and agree with you. |
It's pretty important (see discussion in ckeditor/ckeditor5-design#156). |
I agree that this is enough for now. Let's just hope that we just have a few tricky blockers which are breaking most of the code execution. But we gonna handle this in the future. Thanks for the research @maxbarnas ;) |
I've just noticed that we are using not supported by IE |
Fix: The `getOptimalPosition()` helper should prefer positions that fit inside the viewport even though there are some others that fit better into the limiter. Closes #6181.
No description provided.
The text was updated successfully, but these errors were encountered: