Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues in tests #3804

Closed
maxbarnas opened this issue Aug 23, 2016 · 6 comments
Closed

Compatibility issues in tests #3804

maxbarnas opened this issue Aug 23, 2016 · 6 comments
Assignees
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@maxbarnas
Copy link
Contributor

Related: #312.

@maxbarnas maxbarnas self-assigned this Aug 23, 2016
@maxbarnas
Copy link
Contributor Author

Currently, I added fake polyfill for String.prototype.normalize() to check if it is the real problem in Safari 9. Real, working alternative to this is https://github.com/walling/unorm, but it is around 140 kB. I am open to suggestions. Maybe there is already some package in CKEditor 5, that solves this problem.

I also highlighted problematic tests with // x comment, and will deal with them now.

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2016

cc @scofalik – he mentioned that that normalization isn't necessary (or something similar :)).

@scofalik
Copy link
Contributor

scofalik commented Aug 24, 2016

We can remove normalization for now.

So there should not be .normalize() both in code and in tests. BTW. this may make some test returning wrong results. If that happens, contact me.

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2016

@maxbarnas found also some issue with regexps. Could you elaborate on that, @maxbarnas? Perhaps @scofalik will be able to help you. I only know that ES6 added support for multi-byte chars in regexps, so perhaps their transpilation fails somehow... but OTOH, it should make tests fail.

@maxbarnas
Copy link
Contributor Author

@Reinmar
Copy link
Member

Reinmar commented Sep 15, 2016

This issue covered only a part of problems. There's a followup in #325.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 3 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants