[Chrome] Error throws in the image description after random typing

[ma2ciek]

Steps to reproduce

1. Go to https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/features/image.html or https://ckeditor5.github.io/
2. Type randomly in the image description

Error:

[Reinmar]

Hm... confirmed. When I type blabla quick enough the error is thrown.

[Reinmar]

I can't reproduce this issue on http://localhost:8125/ckeditor5-image/tests/manual/caption.html though. And I can do this on http://localhost/ckeditor5/build/docs/ckeditor5/0.11.0/examples/builds/classic-editor.html. Interesting. It seems that page styling affects it.

[Reinmar]

Yeah, that's definitely due to styling because when I loaded the docs before Umberto generated their CSS, I could not reproduce this issue.

[ma2ciek]

It's interesting that styling might easily destroy the editor.

[Reinmar]

OK, for some reason, a common ancestor of these mutations is a text node. Such situation should not be handled by _handleContainerChildrenMutations(). I wonder what's inside the mutations array.

[Reinmar]

OK, it turns out that this is Grammarly:

It seems that in #267 we missed that Grammarly kicks in in nested editables.

Before we'll ping Grammarly's team, we need to figure out whether we can't just add .ck-editor__editable to nested editables (which, I guess, would disable Grammarly).

cc @oleq

[oleq]

We could add this class but it will require some refactoring of the styles across the project. There are many usages of the .ck-editor__editable in various stylesheets and we must understand their purpose, then rewrite the styles to consider the more generic role of the class.

[Reinmar]

@oleq, could you estimate how hard would this change be? And if it makes sense in general? I see that right now, nested editable has only the .ck-editable class... which is odd. Unification sound like a thing we should do.

[oleq]

The change is not hard but it is spread across multiple repositories and, most certainly, Letters too. I think the right moment to do this will be after #420, though.

[oleq]

I cannot reproduce this issue. Can anyone confirm?

[Reinmar]

Not this one, but e.g. this:

Grammarly inserts bazillion text nodes with spaces into the editor when you type some random letters quickly. It doesn't do that when it's completely disabled.

[oleq]

OK. I check that and the .ck-editor__editable class fixes the problem. I'll prepare a multi-repo PR.