Docs: Updated snippet styles to the latest nested editable CSS class naming convention #917
Conversation
|
WDYT about this change after making it? Does it make sense to use the same class for root and nested editables? Or does it bring more issues than it needs to do? |
docs/assets/snippet-styles.css
Outdated
| @@ -74,12 +74,12 @@ It breaks CKEditor 5 (see how <p><code>[]</code></p> looks). */ | |||
| padding: 0; | |||
| } | |||
|
|
|||
| #snippet-inline-editor .ck-editor__editable { | |||
| #snippet-inline-editor .ck-editor__editable:not(.ck-editor__nested-editable) { | |||
There was a problem hiding this comment.
Can't we use .ck-content here? It would pick just the right element. And kinda makes sense semantically too, doesn't it? You want to align the style of the editor contents so it looks well.
|
Before you'll answer, please also see https://github.com/ckeditor/ckeditor5/pull/917/files#r176673884. |
TBH, I haven't seen any issues. It definitely fixes all the issues caused by Grammarly, though. |
szymonkups
force-pushed
the
t/ckeditor5/578
branch
4 times, most recently
from
76c29c9 to
e97c33d
Compare
szymonkups
force-pushed
the
t/ckeditor5/578
branch
from
e97c33d to
35e45ad
Compare
Suggested merge commit message (convention)
Docs: Updated snippet styles to the latest nested editable CSS class naming convention (see #578).
Additional information
Requires: ckeditor/ckeditor5-widget#36