Brought back previously reverted changes to elementToStructure() throwing when invoked for an element that allows $text"" #11239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… element that allows $text""
…hildren were produced as a workaround for elementToStructure() disallowing conversion of model elements with $text.
…re() is impossible.
oleq
deleted the
revert-11233-revert-11229-ck/11163-disallowed-text-in-element-to-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal (engine):
elementToStructure()should throw when invoked for an element that allows$text. Closes #11163.For the record, we decided to bring back the error thrown by
elementToStructure()when downcasting an element that allows$textbut at the same time, we got rid of the warning (validation) inelementToElement()which now works as a workaround for people who cannot useelementToStructuredue to the error. This is not perfect but OTOH it is hard to predict how many integrations downcast model elements to structures with text so let's give them some error&warning-free solution.