Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brought back previously reverted changes to elementToStructure() throwing when invoked for an element that allows $text"" #11239

Merged
merged 5 commits into from
Feb 8, 2022
+67 −42
Merged

Brought back previously reverted changes to elementToStructure() throwing when invoked for an element that allows $text"" #11239

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb18f4a
Revert "Revert "elementToStructure() should throw when invoked for an…
oleq Feb 8, 2022
50dd19a
Docs: Extended docs of the conversion-element-to-structure-disallowed…
oleq Feb 8, 2022
5c4c1fb
Removed warning from elementToElement() helper logged when multiple c…
oleq Feb 8, 2022
669b780
Tests: Used elementToElement() in widget tests where elementToStructu…
oleq Feb 8, 2022
15f202d
Docs.
oleq Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Docs.
@oleq
oleq committed Feb 8, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 15f202d1f4d484cc163ccb0cc723554f2a299f77
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/src/conversion/downcasthelpers.js
View file
Original file line number Diff line number Diff line change
@@ -1725,7 +1725,7 @@ function downcastElementToStructure( config ) {
* }
* } );
*
* In such case, {@link module:engine/conversion/conversion~Conversion#elementToElement `elementToElement()`} helper
* In such case, {@link module:engine/conversion/downcasthelpers~DowncastHelpers#elementToElement `elementToElement()`} helper
* can be used instead to get around this problem:
*
* editor.conversion.for( 'downcast' ).elementToElement( {