Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updated snippet styles to the latest nested editable CSS class naming convention #917

Merged
merged 5 commits into from
Mar 30, 2018
Merged

Docs: Updated snippet styles to the latest nested editable CSS class naming convention #917

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd389a5
Docs: Updated snippet styles to the latest nested editable CSS class …
oleq Mar 21, 2018
f4c89e1
Tests: Configured branches in mgit.json.
oleq Mar 21, 2018
4681398
Docs: Simplified snippet-styles thanks to the .ck-content class.
oleq Mar 23, 2018
c201acc
Merge branch 'master' into t/ckeditor5/578
oleq Mar 30, 2018
35e45ad
Reset mgit.json.
szymonkups Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/assets/snippet-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ It breaks CKEditor 5 (see how <p><code>[]</code></p> looks). */
padding: 0;
}

#snippet-inline-editor .ck-editor__editable {
#snippet-inline-editor .ck-editor__editable:not(.ck-editor__nested-editable) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use .ck-content here? It would pick just the right element. And kinda makes sense semantically too, doesn't it? You want to align the style of the editor contents so it looks well.

margin-bottom: 1rem;
padding: 2rem;
}

#snippet-inline-editor .ck-editor__editable:not(.ck-focused) {
#snippet-inline-editor .ck-editor__editable:not(.ck-editor__nested-editable):not(.ck-focused) {
border: 1px solid rgba(0, 0, 0, 0.15);
}

Expand Down
6 changes: 3 additions & 3 deletions mgit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@
"@ckeditor/ckeditor5-font": "ckeditor/ckeditor5-font",
"@ckeditor/ckeditor5-heading": "ckeditor/ckeditor5-heading",
"@ckeditor/ckeditor5-highlight": "ckeditor/ckeditor5-highlight",
"@ckeditor/ckeditor5-image": "ckeditor/ckeditor5-image",
"@ckeditor/ckeditor5-image": "ckeditor/ckeditor5-image#t/ckeditor5/578",
"@ckeditor/ckeditor5-link": "ckeditor/ckeditor5-link",
"@ckeditor/ckeditor5-list": "ckeditor/ckeditor5-list",
"@ckeditor/ckeditor5-markdown-gfm": "ckeditor/ckeditor5-markdown-gfm",
"@ckeditor/ckeditor5-paragraph": "ckeditor/ckeditor5-paragraph",
"@ckeditor/ckeditor5-theme-lark": "ckeditor/ckeditor5-theme-lark",
"@ckeditor/ckeditor5-theme-lark": "ckeditor/ckeditor5-theme-lark#t/ckeditor5/578",
"@ckeditor/ckeditor5-typing": "ckeditor/ckeditor5-typing",
"@ckeditor/ckeditor5-ui": "ckeditor/ckeditor5-ui",
"@ckeditor/ckeditor5-undo": "ckeditor/ckeditor5-undo",
"@ckeditor/ckeditor5-upload": "ckeditor/ckeditor5-upload",
"@ckeditor/ckeditor5-utils": "ckeditor/ckeditor5-utils",
"@ckeditor/ckeditor5-widget": "ckeditor/ckeditor5-widget"
"@ckeditor/ckeditor5-widget": "ckeditor/ckeditor5-widget#t/ckeditor5/578"
}
}