Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow reuse of icmp/ping code in vizroute #147

Merged
merged 18 commits into from
Aug 24, 2024
Merged

Conversation

clambin
Copy link
Owner

@clambin clambin commented Aug 23, 2024

No description provided.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 88.79056% with 38 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (4dee77f) to head (eebf743).
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/ping/icmp/icmp.go 86.90% 15 Missing and 7 partials ⚠️
pkg/ping/ping.go 81.70% 12 Missing and 3 partials ⚠️
internal/cmd/pinger.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   76.87%   85.93%   +9.06%     
==========================================
  Files           7       11       +4     
  Lines         320      640     +320     
==========================================
+ Hits          246      550     +304     
- Misses         65       66       +1     
- Partials        9       24      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clambin clambin merged commit 72c2370 into master Aug 24, 2024
10 checks passed
@clambin clambin deleted the refactor branch August 24, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant