Improve bash completion with compopt

[sudotac]

This PR tries to improve bash completion support.

• Fix clap_complete: File path is completed too early in bash #5239
• Add support for ValueHint::DirPath
• Suppress a useless space appended during completion for ValueHint::Other

[epage]

Could you insert a commit at the beginning that updates complete for these cases and then in each commit as things get fixed, the asserts in that test can be updated?

We've added support for testing completions but it'd be a lot of work to go back and add them for all previous issues but I'd like for us to be making sure we cover them for future ones.

[epage]

Also, will this cause problems for people on older bash? See #5190.

[sudotac]

Moved the test change to 6e1fae9. I hope I fixed this correctly.

Also, will this cause problems for people on older bash? See #5190.

I think it would work on bash 4.0 or later.
According to the bash changelog (warning: very long), compopt was introduced in bash 4.0 and the options (-o filenames, -o plusdirs and -o nospace) are available on older versions.

In my opinion, bash 4.0 is old enough to be a minimum supported version.
As far as I've searched on repology, no "major" distribution supports bash 4.0 or older. (It depends on what is "major" though...)

[epage]

In my opinion, bash 4.0 is old enough to be a minimum supported version.
As far as I've searched on repology, no "major" distribution supports bash 4.0 or older. (It depends on what is "major" though...)

The problem is macOS...

[sudotac]

The problem is macOS...

Sorry, I confused it with macPorts. Then, this change will cause the same compatibility issue on macOS. It is necessary to check bash version.

[sudotac]

I found out we cannot add tests for 22bf919 for now because white spaces are trimmed by runtime.complete().

[epage]

I found out we cannot add tests for 22bf919 for now because white spaces are trimmed by runtime.complete().

Resolved in #5310

[sudotac]

Thank you very much!
I've added a test for the remaining one.

[epage]

Thanks!