-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow primitives to assign to multiple results #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a935a2
to
f325ea0
Compare
f325ea0
to
a2dee77
Compare
0898267
to
fec6fbd
Compare
37b701c
to
806b84b
Compare
christiaanb
approved these changes
Nov 3, 2020
806b84b
to
7e960a8
Compare
A multi result primitive assigns its results to multiple result variables instead of one. Besides producing nicer HDL it works around issues with synthesis tooling described in: #1555 This transformation rewrites primitives indicating they can assign their results to multiple signals, such that netlist can easily render it. Example: @ prim :: forall a. a -> (a, a) @ will be rewritten to: @ \a0 -> let r = prim @t0 a0 r0 r1 -- With 'Clash.Core.Term.MultiPrim' r0 = multiPrimSelect r0 r r1 = multiPrimSelect r1 r in (x, y) @ Netlist will not render any @multiPrimSelect@ primitives. Similar to primitives having a /void/ return type, /r/ is not rendered either. This transformation is currently hardcoded to recognize tuples as return types, not any product type. It will error if it sees a multi result primitive with a non-tuple return type. Closes #1555
0b3d69b
to
d751b5e
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach: