Merge upstream #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass a config to the error handler instead of using Temporal.configuration
* Fix issue with GRPC error lookup in Retryer * Rename spec file for retryer to contain _spec
* Start syncing id and domain on workflow context metadata * Fixed tests Co-authored-by: DeRauk Gibble <[email protected]>
* Add YARD documentation for Temporal::Client * Add yard gem * Fix @option tag * Typo fix
#112) * Add signal arguments to start_workflow (to support signal_with_start) * Move signal arguments to the options hash * PR feedback * Fix merge error
…ntTarget objects (#118)
* Separate options from keyword args in #start_workflow * fixup! Separate options from keyword args in #start_workflow
* Refactor metadata generation * Make task queue available on workflow metadata, add example test * Expose workflow start time metadata
* Add describe_namespace * Feedback
* Fix event target map entry for ACTIVITY_CANCELED event * Fix cancellation of a non-started activity * fixup! Fix event target map entry for ACTIVITY_CANCELED event
gvieira
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges upstream changes from
coinbase/temporal-rubyinto this repository. Main purpose is fixing some errors we saw that I believe are fixed by coinbase#109I don't know much about Temporal, and the size of the changes is a little bit of a red flag to me - especially because they haven't released it yet. Making this PR took no time at all though, I figured we could at least look it over.