Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate options from keyword args in #start_workflow #117

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

antstorm
Copy link
Contributor

This change should not affect the behaviour in any way, but it makes a split between options: and **args a bit more visible and fixes documentation (right now it's not showing different options available because there isn't an options: input arg).

The unchanged behaviour and API should be guaranteed by the specs that we have in place (e.g. spec/unit/lib/temporal/client_spec.rb:96)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@antstorm antstorm added the sync pending Needs to be ported to cadence-ruby label Nov 11, 2021
@antstorm antstorm merged commit 824652b into master Nov 17, 2021
@antstorm antstorm deleted the separate-options-arg branch November 17, 2021 15:18
gvieira pushed a commit to clearbit/temporal-ruby that referenced this pull request Dec 21, 2021
* Pass config to the error handler instead of using the global config

* Fix example tests

* Make the config property in the workflow context publicly readable

* [Fix] Retryer GRPC error lookup (coinbase#109)

* Fix issue with GRPC error lookup in Retryer

* Rename spec file for retryer to contain _spec

* [Feature] Add id and domain to workflow context's metadata (coinbase#110)

* Start syncing id and domain on workflow context metadata

* Fixed tests

Co-authored-by: DeRauk Gibble <[email protected]>

* Explicit docker-compose project name (coinbase#114)

* Add YARD documentation for Temporal::Client (coinbase#113)

* Add YARD documentation for Temporal::Client

* Add yard gem

* Fix @option tag

* Typo fix

* Add signal arguments to start_workflow (support for signal_with_start) (coinbase#112)

* Add signal arguments to start_workflow (to support signal_with_start)

* Move signal arguments to the options hash

* PR feedback

* Fix merge error

* Extend #wait_for to take multiple futures and a condition block (coinbase#111)

* Differentiate TARGET_WILDCARD and WILDCARD, allow comparison with EventTarget objects (coinbase#118)

* Turn off schedule_to_start activity timeout by default (coinbase#119)

* Separate options from keyword args in #start_workflow (coinbase#117)

* Separate options from keyword args in #start_workflow

* fixup! Separate options from keyword args in #start_workflow

* Surface additional workflow metadata on workflow context (coinbase#120)

* Refactor metadata generation

* Make task queue available on workflow metadata, add example test

* Expose workflow start time metadata

* Add memos (coinbase#121)

* Add describe_namespace (coinbase#122)

* Add describe_namespace

* Feedback

* Improve header serialization and propagation (coinbase#124)

* [Fix] Non-started activity cancellation (coinbase#125)

* Fix event target map entry for ACTIVITY_CANCELED event

* Fix cancellation of a non-started activity

* fixup! Fix event target map entry for ACTIVITY_CANCELED event

Co-authored-by: DeRauk Gibble <[email protected]>
Co-authored-by: DeRauk Gibble <[email protected]>
Co-authored-by: Anthony Dmitriyev <[email protected]>
Co-authored-by: nagl-stripe <[email protected]>
Co-authored-by: jeffschoner-stripe <[email protected]>
Co-authored-by: Drew Hoskins <[email protected]>
calum-stripe pushed a commit to calum-stripe/temporal-ruby that referenced this pull request Mar 28, 2023
…kins_turn_the_page

Paginate through empty workflow history pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync pending Needs to be ported to cadence-ruby
Development

Successfully merging this pull request may close these issues.

None yet

2 participants