cider-grimoire displays the entire HTML source

[babysnakes]

When running cider-grimoire it displays the entire html source, not the rendered html.

Using latest from melpa and emacs 24.4.

Thanks in advance.

[bbatsov]

Could you provide me with a way to reproduce this? cider-grimoire actually fetches plain text from grimoire, so I'm a bit puzzled by your problem.

[babysnakes]

You can find my emacs setup here. I'm using 24.4 on the latest macos (compiled simply with ./configure --with-ns). If that doesn't help I can either share screen with you or (even better) launch an ec2 server and give you access provided the problem replicates there).

[babysnakes]

I just tried it on ubuntu 14.04 and it doesn't replicate. I have an older mac and I'll try it there, but it'll take me a couple of days.

[arrdem]

Confirmed. Watching Grimoire's logs while using this feature shows that a text/html request is being made when a text/plain request should be made. Not sure how this happened since this feature was working not long ago.

[bbatsov]

Can't imagine how something like this might happen. See the relevant code.

[arrdem]

Hum... watching the logs on the live site rn lemme play with it some

[arrdem]

Okay...

-> % curl -H "Content-Type: text/plain" grimoire.arrdem.com/1.6.0/clojure.core/conj
# 1.6.0 - clojure.core - conj

## Arities
[coll x]
[coll x & xs]

## Documentation
  conj[oin]. Returns a new collection with the xs
    'added'. (conj nil item) returns (item).  The 'addition' may
    happen at different 'places' depending on the concrete type.
## User Documentation
No user commentary. Care to add some?
....

[arrdem]

Something's screwey here...

1. Initially able to reproduce the above failure
2. opened cider-grimoire.el, edited headers to text/html
3. reloaded, continued to fail as expected
4. edited to text/plain
5. reloaded, worked

the fuck

[babysnakes]

@arrdem, thanks for replicating the issue. I don't have access to the grimoire logs :) but I used tcpdump to catch the request in both curl and emacs. When running from emacs the request doesn't seem to include the content type header. Both tcpdump output can be found here. You can view them with tcpdump -qns 0 -X -r output-curl.pcap or with wireshark.

I looked at the function at cider-interaction.el (my source is about 2 weeks old) and it looked ok. Don't know what could go wrong. Is there a way to look at the elc file?

[arrdem]

My initial guess is that this is an artifact of .elc caching somehow, but that doesn't make a ton of sense since I only have one version of CIDER on my emacs load path. I may have time to experiment with this in the morning. Real question is whether a fresh install of CIDER on an otherwise clean/empty Emacs instance exhibits this issue. My guess is not, but that'll indicate whether we're the problem or whether CIDER is.

[babysnakes]

Ok, I did some more experimentation (although I'm not sure what to make of it):

• Deleted the elisp directory and installed packages from scratch - still getting html.
• Did a full git clean -fxd and installed packages from scratch - still getting html.
• Repeated the procedure perform by @arrdem (changing to html and then back to plain - with byte-compile after each change) - got plain text version
• Restored my old emacs directory and just byte compiled cider-interaction.el (remember I have old version) - got plain text version

Could it be that somehow the initial byte compile during installation messes up things?

[bbatsov]

Could it be that somehow the initial byte compile during installation messes up things?

Can't imagine how something like this could happen, but I guess everything is possible. Is this behaving correctly when you don't byte compile anything? I usually use the melpa package (which gets byte-compiled automatically) and I've never run into this problem.

[babysnakes]

I also use melpa.

[arrdem]

Ditto on melpa.

[Kungi]

I also use the melpa package (updated today). When I remove the .elc files from the cider package folder and restart emacs it works. When I use the byte compiled version it only shows html output.

[pw4ever]

Confirmed, with MELPA: cider-20141121.1705.

$ curl -H "Content-Type: text/plain" grimoire.arrdem.com/1.6.0/clojure.core/conj
<html>
<head><title>301 Moved Permanently</title></head>
<body bgcolor="white">
<center><h1>301 Moved Permanently</h1></center>
<hr><center>nginx/1.4.6 (Ubuntu)</center>
</body>
</html>

but

$ curl -H "Content-Type: text/plain" conj.io/1.6.0/clojure.core/conj            
# 1.6.0 - clojure.core - conj

## Arities
[coll x]
[coll x & xs]

## Documentation
  conj[oin]. Returns a new collection with the xs
    'added'. (conj nil item) returns (item).  The 'addition' may
    happen at different 'places' depending on the concrete type.
## User Documentation
No user commentary. Care to add some?
...

A change of the code from

(defconst cider-grimoire-url "http://grimoire.arrdem.com/")

to

(defconst cider-grimoire-url "http://conj.io/")

fixes the problem.

[arrdem]

Oops. Sorry @pw4ever I was expecting the redirect to be user-transparent. Re-enabling the grimoire subdomain until this patch goes through.

[magnars]

Seems like this issue is back. (see #923)

Doing curl -i -H "Content-Type: text/plain" conj.io/1.6.0/clojure.core/conj I get:

HTTP/1.1 302 Found
Server: nginx/1.4.6 (Ubuntu)
Date: Mon, 22 Dec 2014 14:37:00 GMT
Content-Length: 0
Connection: keep-alive
Location: /store/org.clojure/clojure/1.6.0/clojure.core/conj

Based on the resolution last time, maybe it is again dropping the plain-text headers after the redirect?

[arrdem]

@magnars looking at the logs I'd agree with that assessment. The latest version of CIDER works fine. I think what I'll do is hack the Grimoire routes to handle requests from the emacs client differently in my upgrade redirect logic.

[arrdem]

clojure-grimoire/grimoire@bf5e277

Should be fixed now.

[johngit22]

Thank-You this was interesting and enlightening to play with for a little
while... Merry Xmas to you as well Reid

On Mon, Dec 22, 2014 at 6:35 PM, Reid D McKenzie [email protected]
wrote:

clojure-grimoire/grimoire@bf5e277
clojure-grimoire/grimoire@bf5e277

Should be fixed now.

—
Reply to this email directly or view it on GitHub
#867 (comment).

John Boyd

[arrdem]

Grimoire 0.4.5 live, provides special handling for legacy versions of CIDER based on user-agent strings to deliver text pages rather than redirects. I was nice and didn't add a snarky message to upgrade CIDER.

@johngit22 Thanks, same to you!