[Fix #867] Update Grimoire URL to fix (cider-grimoire-lookup) regression due to HTTP 301 (Moved Permanently) #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Please, update the changelog and change the commit message to |
|
Thanks for the response. The CI failure was due to mismatch in test suite to the new URL. Also changed is the README.md about Grimoire. |
pw4ever
changed the title
|
The code looks good, but I don't see a CHANGELOG.md entry. Also - squash all commits into one. |
|
@bbatsov I have updated CHANGELOG.md and followed this tutorial to squash the commits. |
… HTTP 301 (Moved Permanently) to the old Grimoire URL. Grimoire recently migrates to "http://conj.io". The old URL used in (cider-grimoire-lookup) would drop the "Content-Type: text/plain" request enroute of a HTTP 301 redirection. Updating the Grimoire URL to "http://conj.io" fixes the issue.
pw4ever
changed the title
bbatsov
added a commit
that referenced
this pull request
Nov 24, 2014
[Fix #867] Update Grimoire URL to fix (cider-grimoire-lookup) regression due to HTTP 301 (Moved Permanently)
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#867 (comment)