Support DFX Workload Calls #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2021
Chaffelson
changed the title
asdaraujo
reviewed
Feb 2, 2022
wmudge
requested changes
Feb 25, 2022
There was a problem hiding this comment.
Please review @asdaraujo comments - they look good to me. Also, is there a reference to the API docs for the df extension used in create_deployment?
Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Add support for readyflows Remove comment support from df_service until string limitations are inline with rest of platform Add support for terminating deployed flows when disabling the DFX Service Signed-off-by: Daniel Chaffelson <[email protected]>
Chaffelson
force-pushed
the
df_deployments
branch
from
f808a16 to
5825e5d
Compare
Improved application deployment playbook to only attempt Kafka flow deployment when Kafka Datahub is found Improved cdpy CRN validation by moving substring definitions to a constant and simplifying the validation logic Improved cdpy.df.describe_service to only run if the dataflow CRN is correctly resolved Force renamed readyflowCRN for an imported ReadyFlow to be addedReadyflowCrn to improve usability Renamed some tasks to improve distinction between similar but different activities like enabling the DF service vs deploying a DF flow Corrected various minor documentation points for DF modules Normalized responses to readyflow_info, deployment_info, and customflow_info to use listings of the full description of objects to simplify user experience Signed-off-by: Daniel Chaffelson <[email protected]>
wmudge
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum CDPCLI version to 0.9.48-beta
Set Static Credentials to allow optional access / private key with an access_token
Establish new feature group WORKLOAD_SERVICES with first option of dfworkload
Modify CDPCLI client builder to fetch and use the Bearer token for a workload service transparently from the Environment in passed parameters
Improve CDP CRN validation to be more specific to different CRN types
Update terminology in df.py to reflect separation of DataFlow Deployment from DataFlow Service
Add new functions to df.py to support workload Deployments, this relies on the dfworkload extensions in CDPCLI
Signed-off-by: Daniel Chaffelson [email protected]