Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DataFlow Deployments #45

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

Chaffelson
Copy link
Collaborator

@Chaffelson Chaffelson commented Dec 16, 2021

Requires:
cloudera-labs/cdpy#40

Add df_customflow_info module, a custom flow is a user supplied flow definition and behaves differently from a readyflow
Add df_deployment module, for actually deploying or removing any kind of flow
Add df_deployment_info module, info on deployments
Add df_readyflow module, for adding or removing ReadyFlows from a given Tenant
Add df_readyflow_info module
Update df_service to support Tags for the DFX Service
Correct check_mode behavior for df_service, and fix idempotent termination issue
Fix docs and classnames in df_service_info

Note that significant logic is pushed down into cdpy to handle resolution of various CRNs and Names, and the extensive deployment logic for DF Deployments is lifted from CDPCLI.

Copy link
Contributor

@asdaraujo asdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nit-picks

plugins/modules/df_customflow_info.py Outdated Show resolved Hide resolved
plugins/modules/df_customflow_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment.py Show resolved Hide resolved
plugins/modules/df_readyflow_info.py Show resolved Hide resolved
plugins/modules/df_service.py Outdated Show resolved Hide resolved
plugins/modules/df_customflow_info.py Show resolved Hide resolved
plugins/modules/df_customflow_info.py Outdated Show resolved Hide resolved
plugins/modules/df_customflow_info.py Outdated Show resolved Hide resolved
plugins/modules/df_customflow_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Show resolved Hide resolved
plugins/modules/df_readyflow.py Show resolved Hide resolved
plugins/modules/df_readyflow.py Outdated Show resolved Hide resolved
plugins/modules/datahub_definition_info.py Outdated Show resolved Hide resolved
plugins/modules/df_deployment_info.py Outdated Show resolved Hide resolved
@wmudge wmudge added the enhancement New feature or request label Mar 31, 2022
Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Add support for readyflows
Remove comment support from df_service until string limitations are inline with rest of platform
Add support for terminating deployed flows when disabling the DFX Service

Signed-off-by: Daniel Chaffelson <[email protected]>
Added DFX to cloudera.exe.info role
Set DFX Deployments to only be attempted when defined
Added Example DFX Flow deployment to examples/cdf definition in cloudera-deploy

Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Improved application deployment playbook to only attempt Kafka flow deployment when Kafka Datahub is found
Improved cdpy CRN validation by moving substring definitions to a constant and simplifying the validation logic
Improved cdpy.df.describe_service to only run if the dataflow CRN is correctly resolved
Force renamed readyflowCRN for an imported ReadyFlow to be addedReadyflowCrn to improve usability
Renamed some tasks to improve distinction between similar but different activities like enabling the DF service vs deploying a DF flow
Corrected various minor documentation points for DF modules
Normalized responses to readyflow_info, deployment_info, and customflow_info to use listings of the full description of objects to simplify user experience

Signed-off-by: Daniel Chaffelson <[email protected]>
@wmudge wmudge merged commit 3a785a8 into cloudera-labs:devel Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants