-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for DataFlow Deployments #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdaraujo
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nit-picks
wmudge
requested changes
Feb 25, 2022
Chaffelson
force-pushed
the
df_deployments
branch
from
March 22, 2022 19:27
12468ef
to
2272e5c
Compare
wmudge
requested changes
Mar 31, 2022
wmudge
approved these changes
Apr 1, 2022
Chaffelson
force-pushed
the
df_deployments
branch
from
April 1, 2022 15:30
0a04176
to
9ea3783
Compare
Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Add support for readyflows Remove comment support from df_service until string limitations are inline with rest of platform Add support for terminating deployed flows when disabling the DFX Service Signed-off-by: Daniel Chaffelson <[email protected]>
Added DFX to cloudera.exe.info role Set DFX Deployments to only be attempted when defined Added Example DFX Flow deployment to examples/cdf definition in cloudera-deploy Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Improved application deployment playbook to only attempt Kafka flow deployment when Kafka Datahub is found Improved cdpy CRN validation by moving substring definitions to a constant and simplifying the validation logic Improved cdpy.df.describe_service to only run if the dataflow CRN is correctly resolved Force renamed readyflowCRN for an imported ReadyFlow to be addedReadyflowCrn to improve usability Renamed some tasks to improve distinction between similar but different activities like enabling the DF service vs deploying a DF flow Corrected various minor documentation points for DF modules Normalized responses to readyflow_info, deployment_info, and customflow_info to use listings of the full description of objects to simplify user experience Signed-off-by: Daniel Chaffelson <[email protected]>
Signed-off-by: Daniel Chaffelson <[email protected]>
Chaffelson
force-pushed
the
df_deployments
branch
from
April 1, 2022 15:47
9ea3783
to
d3201f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
cloudera-labs/cdpy#40
Add df_customflow_info module, a custom flow is a user supplied flow definition and behaves differently from a readyflow
Add df_deployment module, for actually deploying or removing any kind of flow
Add df_deployment_info module, info on deployments
Add df_readyflow module, for adding or removing ReadyFlows from a given Tenant
Add df_readyflow_info module
Update df_service to support Tags for the DFX Service
Correct check_mode behavior for df_service, and fix idempotent termination issue
Fix docs and classnames in df_service_info
Note that significant logic is pushed down into cdpy to handle resolution of various CRNs and Names, and the extensive deployment logic for DF Deployments is lifted from CDPCLI.