Remove more inefficient counting #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
reviewed
Nov 17, 2022
will-gant
force-pushed
the
more-counting-optimizations
branch
from
a75d27d to
661fb33
Compare
philippthun
approved these changes
Nov 18, 2022
will-gant
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Small optimizations to a few DB queries related to counting.
An explanation of the use cases your change solves
Two small things:
Sequel'sany?andempty?methods instead ofcountwhen all we want to know is whether a non-zero number of matching records exist. Essentially a follow-up to Misc db optimizations #3052resource.associated_resources.map(&:other_associated_resources), which results in a single query to fetchassociated_resourcesand then, for each one found, a separate query to count itsother_associated_resources. This can be replaced with a single query with a join andempty?\any?.Links to any other associated PRs
n/a
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests