Remove more inefficient counting (cloudfoundry#3067)

app/access/base_access.rb

@@ -25,7 +25,7 @@ def has_read_scope?
     end
 
     def object_is_visible_to_user?(object, user)
-      object.class.user_visible(user, false).where(guid: object.guid).count > 0
+      object.class.user_visible(user, false).where(guid: object.guid).any?
     end
 
     def admin_user?

app/access/managed_service_instance_access.rb

@@ -58,7 +58,7 @@ def allowed?(service_instance)
       return true if admin_user?
 
       if service_instance.new? || service_instance.changed_columns.include?(:service_plan_id)
-        return ServicePlan.user_visible(context.user, admin_user?).filter(guid: service_instance.service_plan.guid).count > 0
+        return ServicePlan.user_visible(context.user, admin_user?).filter(guid: service_instance.service_plan.guid).any?
       end
 
       true

app/access/service_plan_access.rb

@@ -71,7 +71,7 @@ def index_with_token?(_)
     end
 
     def object_is_visible_to_user?(service_plan, user)
-      VCAP::CloudController::ServicePlan.user_visible(user, false, :read).where(guid: service_plan.guid).count > 0
+      VCAP::CloudController::ServicePlan.user_visible(user, false, :read).where(guid: service_plan.guid).any?
     end
   end
 end

app/actions/service_offering_delete.rb

@@ -3,7 +3,7 @@ class ServiceOfferingDelete
     class AssociationNotEmptyError < StandardError; end
 
     def delete(service_offering_model)
-      association_not_empty! unless service_offering_model.service_plans.empty?
+      association_not_empty! if ServicePlan.where(service_id: service_offering_model.id).any?
       service_offering_model.destroy
     end
 

app/actions/space_delete.rb

@@ -82,7 +82,13 @@ def delete_apps(space_model)
     def delete_service_brokers(space_model)
       broker_remover = service_broker_remover(@services_event_repository)
       private_service_brokers = space_model.service_brokers
-      deletable_brokers = private_service_brokers.reject { |broker| broker.service_plans.map(&:service_instances).flatten.any? }
+      deletable_brokers = private_service_brokers.reject do |broker|
+        ServiceInstance.
+          join(:service_plans, id: :service_instances__service_plan_id).
+          join(:services, id: :service_plans__service_id).
+          where(services__service_broker_id: broker.id).
+          any?
+      end
 
       deletable_brokers.each do |broker|
         broker_remover.remove(broker)

app/controllers/runtime/routes_controller.rb

@@ -370,7 +370,7 @@ def check_route_reserved(domain_guid, host, path, port)
         routes = routes.where(path: path) if path
         routes = routes.where(port: port) if port
 
-        return [HTTP::NO_CONTENT, nil] if routes.count > 0
+        return [HTTP::NO_CONTENT, nil] if routes.any?
       end
       [HTTP::NOT_FOUND, nil]
     end

app/models/runtime/app_model.rb

@@ -106,7 +106,7 @@ def database_uri
     end
 
     def staging_in_progress?
-      builds.any?(&:staging?)
+      builds_dataset.where(state: BuildModel::STAGING_STATE).any?
     end
 
     def docker?
@@ -122,7 +122,7 @@ def stopped?
     end
 
     def deploying?
-      deployments.any?(&:deploying?)
+      deployments_dataset.where(state: DeploymentModel::DEPLOYING_STATE).any?
     end
 
     def self.user_visibility_filter(user)

lib/database/batch_delete.rb

@@ -12,7 +12,7 @@ def delete
 
       loop do
         set = dataset.limit(amount)
-        break if set.count == 0
+        break if set.empty?
 
         total_count += delete_batch(set)
       end

lib/services/service_brokers/v2/catalog.rb

@@ -122,7 +122,10 @@ def taken_names(new_services_names)
     end
 
     def can_delete_service?(service)
-      service.service_plans_dataset.map(&:service_instances_dataset).map(&:count).all?(0)
+      VCAP::CloudController::ServiceInstance.
+        join(:service_plans, id: :service_instances__service_plan_id).
+        where(service_plans__service_id: service.id).
+        empty?
     end
 
     def updating_service?(new_service, old_service)