Add "default" field to v3 stacks #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The default stack is only configurable by operators. - New apps use the default stack, if no stack is specified in their lifecycle. - There was no way for API users to know what the default stack is on a given Cloud Foundry deployment. - Apps will not change their stack, unless the app lifecycle is updated to a different stack. The default stack does not affect existing applications. - This field may be useful for writing app deploy scripts that automatically update the app's stack to be the default stack. - This could also enable push workflows like `cf push my-app --default-stack` (or something like that).
- Boolean-ish filter adopted from v3 security groups - Enable clients to discover which stack is the operator-configured default stack
- Error message was previously "The query parameter is invalid: Default is not included in the list" for some endpoints, which was unhelpful and NOT luxurious - Slightly modify the error message for some services endpoints
5 tasks
philippthun
approved these changes
Feb 1, 2023
moleske
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Add
defaultfield to v3 stacks.An explanation of the use cases your change solves
cf push my-app --default-stack(or something like that).Links to any other associated PRs
N/A
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests