Fix incorrectly passing shared examples #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect if list endpoint permissions shared example gets unexpected keys in the codes & responses hash - Now, tests using this shared example will fail if they get an unexpected key in the hash - It was easy to accidentally confuse "response_object" with "response_objects", which resulted in incorrectly passing tests that did not check the response body - Fix multiple tests that were incorrectly passing and were detected by this guard
Gerg
changed the title
- Continuation of fix to the same issue for the list endpoint shared example
- Continuation of fix to the same issue for other shared examples - Since there were several places where "errors" were provided in tests, add support for that key, based on other shared example implementations
philippthun
approved these changes
Feb 1, 2023
moleske
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I noticed this issue while working on #3157
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests