Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Provide a way to set custom labels on the Pods Eirini deploys #222

Open
gcapizzi opened this issue May 31, 2021 · 0 comments
Open

Provide a way to set custom labels on the Pods Eirini deploys #222

gcapizzi opened this issue May 31, 2021 · 0 comments
Milestone

Comments

@gcapizzi
Copy link
Contributor

The following fields in eiriniv1.LRP and eiriniv1.Tasl act only as metadata (they get converted to labels):

  • GUID
  • Version
  • Name
  • ProcessType
  • App/Space/OrgName/GUID

Fields like GUID, Name and Version should be replaced by Kubernetes' ways of identifying objects.

The other fields refer to higher-level concepts Eirini shouldn't be aware of. Instead, we should provide clients with a way to specify their own labels and annotations, which we should then apply to all the resources we create (StatefulSets, Pods). In order to do so, we have two alternatives:

  • Add a UserProvidedLabels field (similar to the existing UserProvidedAnnotations
  • Let clients set labels and annotations on our CRs, and replicate those
@gcapizzi gcapizzi added this to the CRDs milestone May 31, 2021
gcapizzi pushed a commit to eirini-forks/cli that referenced this issue Sep 23, 2021
Instead of parsing the kube config ourselves and invoking a credentials
plugin if configured, we can use the client-go similarly to how we used
it for auth-provider users.

The catch is that the exec authenticator sets details on a transport
config object, but it is still possible to extract certificate
information and to use the request wrapping.

This feels slightly more hacky than the auth-provider code. But then
again, the k8s folks seem careful with their private methods, so we
might assume that the public interface will be maintained.

Issue: cloudfoundry/cf-crd-explorations#64
Co-authored-by: Anonymous Eirininaut <[email protected]>
Issue: cloudfoundry/eirini-release#182
Issue: cloudfoundry/eirini-release#184
Issue: cloudfoundry/eirini-release#185
Issue: cloudfoundry/eirini-release#187
Issue: cloudfoundry/eirini-release#186
Issue: cloudfoundry/eirini-release#183
Issue: cloudfoundry/eirini-release#192
Issue: cloudfoundry/eirini-release#193
Issue: cloudfoundry/eirini-release#194
Issue: cloudfoundry/eirini-release#191
Issue: cloudfoundry/eirini-release#196
Issue: cloudfoundry/eirini-release#199
Issue: cloudfoundry/eirini-release#200
Issue: cloudfoundry/eirini-release#219
Issue: cloudfoundry/eirini-release#220
Issue: cloudfoundry/eirini-release#221
Issue: cloudfoundry/eirini-release#218
Issue: cloudfoundry/eirini-release#222
Issue: cloudfoundry/eirini-release#223
Issue: cloudfoundry/eirini-release#224
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant