This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Improve logs for PUT /apps/:guid/:vguid/stop
#192
Milestone
Comments
mnitchev
pushed a commit
to cloudfoundry/eirini
that referenced
this issue
May 12, 2021
Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#201 Issue: cloudfoundry/eirini-release#202 Issue: cloudfoundry/eirini-release#204 Issue: cloudfoundry/eirini-release#205 Issue: cloudfoundry/eirini-release#195 Issue: cloudfoundry/eirini-release#198 Issue: cloudfoundry/eirini-release#211 Issue: cloudfoundry/eirini-release#212 Issue: cloudfoundry/eirini-release#207 Issue: cloudfoundry/eirini-release#190 Issue: cloudfoundry/eirini-release#209
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Georgi Sabev <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
and include base64 encoded response in auth header Find the cred-helper in auth-explore repo NB - hack only! Co-authored-by: Kieron Browne <[email protected]> Co-authored-by: Danail Branekov <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Gets creds from an exec plugin or GCP auth-provider. Sends them as a serialised ExecCredential obj to Shim. Co-authored-by: Giuseppe Capizzi <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Reuse the logic in the `client-go` `AuthProvider` implementations by building an adapter from `http.RoundTripper` to `cc.Connection`. Issue: cloudfoundry/cf-crd-explorations#64 Co-authored-by: Kieron Browne <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Instead of parsing the kube config ourselves and invoking a credentials plugin if configured, we can use the client-go similarly to how we used it for auth-provider users. The catch is that the exec authenticator sets details on a transport config object, but it is still possible to extract certificate information and to use the request wrapping. This feels slightly more hacky than the auth-provider code. But then again, the k8s folks seem careful with their private methods, so we might assume that the public interface will be maintained. Issue: cloudfoundry/cf-crd-explorations#64 Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Anonymous Eirininaut <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Kieron Browne <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Giuseppe Capizzi <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
pushed a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Kieron Browne <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Kieron Browne <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Giuseppe Capizzi <[email protected]> Co-authored-by: Kieron Browne <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
gcapizzi
added a commit
to eirini-forks/cli
that referenced
this issue
Sep 23, 2021
Co-authored-by: Giuseppe Capizzi <[email protected]> Issue: cloudfoundry/eirini-release#182 Issue: cloudfoundry/eirini-release#184 Issue: cloudfoundry/eirini-release#185 Issue: cloudfoundry/eirini-release#187 Issue: cloudfoundry/eirini-release#186 Issue: cloudfoundry/eirini-release#183 Issue: cloudfoundry/eirini-release#192 Issue: cloudfoundry/eirini-release#193 Issue: cloudfoundry/eirini-release#194 Issue: cloudfoundry/eirini-release#191 Issue: cloudfoundry/eirini-release#196 Issue: cloudfoundry/eirini-release#199 Issue: cloudfoundry/eirini-release#200 Issue: cloudfoundry/eirini-release#219 Issue: cloudfoundry/eirini-release#220 Issue: cloudfoundry/eirini-release#221 Issue: cloudfoundry/eirini-release#218 Issue: cloudfoundry/eirini-release#222 Issue: cloudfoundry/eirini-release#223 Issue: cloudfoundry/eirini-release#224
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is how logs look like when an LRP is stopped:
It's not very clear what
handler
means, and we don't see the start and end of the request processing, which could be useful especially once we introduce extra debug logs or just to see request duration. Also, this should probably be aninfo
log. So something like this:Let's also make sure that any errors are logged correctly and only once. Refer to #177562455 for details about how we want to log errors.
Dev Notes
Ensure logs are correlated using lager session IDs. This requires using the
logger.Session
method and passing the logger through method calls. It will not work if the logger is stored in a struct.Logger can be passed as an explicit method argument, or might also be passed as part of the context object that is already passed around (see the https://github.com/cloudfoundry/lager/tree/master/lagerctx package, and note in this story). With lagerctx, there is the risk of accidentally and unknowingly using the fallback discard logger if the original context is somehow lost while passing through methods. So explicitly passing both context and logger as separate method parameters throughout might be the safest option, giving compile-time guarantees of having logging correctly propagated.
The text was updated successfully, but these errors were encountered: