Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO_LOGIN setting is not applied after upgrade from 2.4.0 #4013

Closed
richard-cox opened this issue Nov 7, 2019 · 1 comment
Closed

SSO_LOGIN setting is not applied after upgrade from 2.4.0 #4013

richard-cox opened this issue Nov 7, 2019 · 1 comment
Labels
bug

Comments

@richard-cox
Copy link
Contributor

  • cf push 2.4.0, bind db, set SSO_LOGIN env var to true... SSO log in works fine
  • cf push 2.6.0 ... and log in screen shows username/password
@richard-cox richard-cox added the bug label Nov 7, 2019
richard-cox added a commit that referenced this issue Nov 7, 2019
@richard-cox
Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade
ce61cec 
- affects db migration of console config table to new config table
- fixes #4013
@richard-cox richard-cox mentioned this issue Nov 7, 2019
Merged
@richard-cox
Copy link
Contributor Author

This will related to any deployment that uses SSO_LOGIN with a persistent db.

SSO_LOGIN was incorrectly being set in previous console config table, this was then transferred over to new config table. The console expects previous values to have been explicitly set by user (and as such should take precedents over env vars).

We've pushed a fix that will ensure any upgrade from 2.4.0 --> 2.6.1 will work. For anyone affected by this we recommend either

  • In the db ... deleting the SSO_LOGIN row in the config table
  • In the db ... updating the value of the SSO_LOGIN row in the config table to "true"
  • Binding a fresh db to the console and restarting the app

nwmac pushed a commit that referenced this issue Nov 8, 2019
@richard-cox @nwmac
Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015)
7a2bfc6 
- affects db migration of console config table to new config table
- fixes #4013
@nwmac nwmac closed this as completed Nov 13, 2019
nwmac pushed a commit that referenced this issue Dec 4, 2019
@richard-cox @nwmac
Merge v2-master into master (#4044)
9c44228 
* Follow redirect - needed for repo move

* Update metric used for cells (#4009)

- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed`
- Try new metric first and fall back on old

* Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015)

- affects db migration of console config table to new config table
- fixes #4013

* 2.6.1 Release preparation

* Ingress fix (#4024)

* Fixes ingress and kube 1.16 version issue

* Update Changelog

* More test

* Fix ingress tests

* Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039)

* Fix following merge
nwmac added a commit that referenced this issue Jan 6, 2020
@richard-cox @nwmac @gberche-orange
Merge v2 master to master (#4050)
cfeffa9 
* Follow redirect - needed for repo move

* Update metric used for cells (#4009)

- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed`
- Try new metric first and fall back on old

* Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015)

- affects db migration of console config table to new config table
- fixes #4013

* 2.6.1 Release preparation

* Ingress fix (#4024)

* Fixes ingress and kube 1.16 version issue

* Update Changelog

* More test

* Fix ingress tests

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039)

* Backend changs to support long-running requests

* Fix create service instance from service instance page

* Fix unit tests

* Ensure service plans are sorted by display name
- sometimes these are fetched inline which aren't sorted

* Fix helm chart issue with semver (#4046)

* Handle Long Running Service Instance Operations
- Some brokers take a long time to execute create, update and delete service instance operations
- This time exceeded the amount allowed by browser/jetstream
- We now provide a custom response to the front end when this happens
- Front end then handles this and also shows a custom error message

* Fixes post merge

* Changes and tidy up post review
- Use a common way to get a service name, service link, broker name
- Split out cf specific long running functionality
- Show service as a link in app service instance card
- Show service plan and broker in app service instance card
- Update the service instance entity on Update as well as Delete
  (will show a better 'last operation' value)

* Fixes post merge

* Fix failing unit tests

* Improvements to error/notification process
- Show mini error message, as per create, when updating service instance
- Handle all 5XX status codes as errors
- Update messages to reflect varience of error states
- Show single popover message on error dismiss all button
- Correct error page selector

* Treat calls to multiple endpoints as `global`
- calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler
- this was due to the internal event storing endpoint id as `` instead of one per endpoint
- this happened due to the list of generated endpoints being applied directly to request object in lower function
- treat these as global for the moment

* More fixes

* Fix failing e2e test

* Show last operation and service broker info for service instances (#4038)

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Fix create service instance from service instance page

* Fix unit tests

* Fix failing e2e test

* Fix bad merge

* Fix failing tests

Co-authored-by: Neil MacDougall <[email protected]>
Co-authored-by: Guillaume Berche <[email protected]>
nwmac added a commit that referenced this issue Jan 7, 2020
@richard-cox @nwmac @gberche-orange
Blitz - Add table view to marketplace service table (#4064)
0270198 
* Follow redirect - needed for repo move

* Update metric used for cells (#4009)

- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed`
- Try new metric first and fall back on old

* Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015)

- affects db migration of console config table to new config table
- fixes #4013

* 2.6.1 Release preparation

* Ingress fix (#4024)

* Fixes ingress and kube 1.16 version issue

* Update Changelog

* More test

* Fix ingress tests

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039)

* Backend changs to support long-running requests

* Fix create service instance from service instance page

* Fix unit tests

* Ensure service plans are sorted by display name
- sometimes these are fetched inline which aren't sorted

* Fix helm chart issue with semver (#4046)

* Handle Long Running Service Instance Operations
- Some brokers take a long time to execute create, update and delete service instance operations
- This time exceeded the amount allowed by browser/jetstream
- We now provide a custom response to the front end when this happens
- Front end then handles this and also shows a custom error message

* Fixes post merge

* Changes and tidy up post review
- Use a common way to get a service name, service link, broker name
- Split out cf specific long running functionality
- Show service as a link in app service instance card
- Show service plan and broker in app service instance card
- Update the service instance entity on Update as well as Delete
  (will show a better 'last operation' value)

* Fixes post merge

* Fix failing unit tests

* Improvements to error/notification process
- Show mini error message, as per create, when updating service instance
- Handle all 5XX status codes as errors
- Update messages to reflect varience of error states
- Show single popover message on error dismiss all button
- Correct error page selector

* Treat calls to multiple endpoints as `global`
- calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler
- this was due to the internal event storing endpoint id as `` instead of one per endpoint
- this happened due to the list of generated endpoints being applied directly to request object in lower function
- treat these as global for the moment

* More fixes

* Fix failing e2e test

* Add table view to marketplace service table

* Show last operation and service broker info for service instances (#4038)

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Fix create service instance from service instance page

* Fix unit tests

* Fix failing e2e test

* Fix unit tests

* Fix bad merge

* Fix unit tests

* Fix e2e tests

* Fix removal of `cf` column when there's only one connected cf

Co-authored-by: Neil MacDougall <[email protected]>
Co-authored-by: Guillaume Berche <[email protected]>
nwmac added a commit that referenced this issue Jan 24, 2020
@richard-cox @nwmac @gberche-orange
Merge v2 master to master (#4102)
e708a17 
* Follow redirect - needed for repo move

* Update metric used for cells (#4009)

- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed`
- Try new metric first and fall back on old

* Fix incorrect SSO behaviour following 2.4.0 --> 2.6.0 upgrade (#4015)

- affects db migration of console config table to new config table
- fixes #4013

* 2.6.1 Release preparation

* Ingress fix (#4024)

* Fixes ingress and kube 1.16 version issue

* Update Changelog

* More test

* Fix ingress tests

* Mention STRATOS_BP_DEBUG to troubleshoot staging (#4039)

* Backend changs to support long-running requests

* Fix helm chart issue with semver (#4046)

* Show last operation and service broker info for service instances (#4038)

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Fix create service instance from service instance page

* Fix unit tests

* Fix failing e2e test

* Fix chrome driver version (#4078)

* Fix long running service actions (#4049)

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Fix create service instance from service instance page

* Fix unit tests

* Ensure service plans are sorted by display name
- sometimes these are fetched inline which aren't sorted

* Handle Long Running Service Instance Operations
- Some brokers take a long time to execute create, update and delete service instance operations
- This time exceeded the amount allowed by browser/jetstream
- We now provide a custom response to the front end when this happens
- Front end then handles this and also shows a custom error message

* Changes and tidy up post review
- Use a common way to get a service name, service link, broker name
- Split out cf specific long running functionality
- Show service as a link in app service instance card
- Show service plan and broker in app service instance card
- Update the service instance entity on Update as well as Delete
  (will show a better 'last operation' value)

* Fix failing unit tests

* Fix failing e2e test

* Fix bad merge

* Fixes following merge

* Fix table cell active/bindable icons

* Remove incorrectly merged file

* Fix message for long running delete service instance

* Fix service market place list bug where user provided services didn't show

* Remove dupe file

Co-authored-by: Neil MacDougall <[email protected]>
Co-authored-by: Guillaume Berche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nwmac @richard-cox