Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2 master to master #4050

Merged
merged 42 commits into from
Jan 6, 2020
Merged

Merge v2 master to master #4050

merged 42 commits into from
Jan 6, 2020

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Dec 5, 2019

nwmac and others added 21 commits October 31, 2019 11:19
- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed`
- Try new metric first and fall back on old
- affects db migration of console config table to new config table
- fixes #4013
Release 2.6.1 Release Notes and Version bump
* Fixes ingress and kube 1.16 version issue

* Update Changelog

* More test

* Fix ingress tests
 Mention STRATOS_BP_DEBUG to troubleshoot staging (v2-master)
- sometimes these are fetched inline which aren't sorted
- Some brokers take a long time to execute create, update and delete service instance operations
- This time exceeded the amount allowed by browser/jetstream
- We now provide a custom response to the front end when this happens
- Front end then handles this and also shows a custom error message
Backend changes to support long-running requests
@richard-cox richard-cox added the do not merge Do Not Merge label Dec 5, 2019
@richard-cox richard-cox self-assigned this Dec 5, 2019
- Use a common way to get a service name, service link, broker name
- Split out cf specific long running functionality
- Show service as a link in app service instance card
- Show service plan and broker in app service instance card
- Update the service instance entity on Update as well as Delete
  (will show a better 'last operation' value)
- Show mini error message, as per create, when updating service instance
- Handle all 5XX status codes as errors
- Update messages to reflect varience of error states
- Show single popover message on error dismiss all button
- Correct error page selector
- calls where we generate the endpoint lists (app wall, etc) were handled badly by jetstreamErrorHandler
- this was due to the internal event storing endpoint id as `` instead of one per endpoint
- this happened due to the list of generated endpoints being applied directly to request object in lower function
- treat these as global for the moment
richard-cox and others added 4 commits December 13, 2019 11:20
)

* Show more service instance last operation details

* Show service instance service broker

* Handle last operation & broker in table view

* Show the service broker name in the service list service card

* Fix create service instance from service instance page

* Fix unit tests

* Fix failing e2e test
@richard-cox richard-cox added ready for review and removed do not merge Do Not Merge labels Jan 6, 2020
@nwmac nwmac removed the blocked-pr label Jan 6, 2020
@nwmac nwmac merged commit cfeffa9 into master Jan 6, 2020
@nwmac nwmac deleted the merge-v2-master branch January 6, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants