User favorites

[KlapTrap]

Be able to favorite all of the CF entity types and show them on a new "home page dashboard" page.

This work should be able to be used by any extension and should allow for currently unknown entity types.

The aim of this work is to give users a area where they can see entities they care about in one place (from any level within CF) without having to navigate through the CF hierarchy every time.

[cfdreddbot]

✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA.

[richard-cox]

Home Page - Favourites

• It looks like you don't have any favorites message needs converting to
• CF Summary card links to Deploy Application when cf is disconnected
• Icons needed for home screen Cf/Org/Space/App cards
• cards need to clip long text
  
  • app-multiline-title can be used to avoid card dimension disparity
• the text/type filters should be sticky for a session
• Minor - Flesh out entity card actions
• Cards show focus, needs uniformity with all other cards

Home Page - Recent

• Recent List can be confusing
  • for instance
    • Two cf's in recent list (cf 1 at top and cf 2 at bottom)
    • Visit an app from cf 2 via the favourites list
    • Click on home button
    • Incorrect order shown (cf 1, app from cf 2, cf 2)
• Feels like we should call this 'Frequent' to remove any feeling of 'last visited at top'
• Entity titles in recent card should be clipped & match width set for recent section
  
• Most Recent list should be per console user. At the moment logging in as a different user shows same list - app-multiline-title can hopefully be used here too
• Minor - Option to clear list of all recent entities
• Minor - Option to remove a single item from recent list
• App name (maybe others?) don't update on name change (either if changed in same session, or concurrently in another session and reload)
• Entities in a disconnected endpoint are still shown in recents list (maybe these should just be hidden?)
• Entities in a unregistered endpoint are still shown in recents list (think these should be removed permanently)

Home Page

• Should wrap recent to below favourites on horizontal shrinkage
• Minor - Would be super useful to have the links on the home page as anchors, such that the 'open in new tab' feature works. Feels like this page needs it most due to the potential number of entities that can be visited

[richard-cox]

I've updated the review comment above, plus new items below

History

• new top bar icon means register an endpoint arrow points at wrong place (on endpoint page when no endpoints registered)
• History card titles need to be clipped using app-multiline-title is possible
• Minor - Choice of session tab should be sticky

Home Page

• Personal opinion, labels would read a bit nicer as Top --> Frequent & History --> Recent

[KlapTrap]

I've taken inspiration for the word "top" from firefox, that's what they use when showing you recent/frequently viewed links on the new tab screen.

I don't think clipping is needed, we have all the vertical space we need. I did try app-multiline-title on the favorite cards but it doesn't give good results when the height of the text is different to the meta card standard size.

I'm going to create another ticket with future work, this will include saving state across page views.

[richard-cox]

LGTM, once gates pass will merge

Below is a summary of the follow on work

Home Page - Favourites

• add favourites to services
• add favourites to k8s
• add type icons to favourites cards
• Minor - Flesh out entity card actions
• the text/type filters should be sticky for a session

Home Page - Recent

• persist user top/recent lists over refresh
• Minor - Option to clear list of all recent entities
• Minor - Option to remove a single item from recent list

Home Page

• Minor - Would be super useful to have the links on the home page as anchors, such that the 'open in new tab' feature works. Feels like this page needs it most due to the potential number of entities that can be visited