-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User favorites #3255
Merged
Merged
User favorites #3255
Changes from all commits
Commits
Show all changes
156 commits
Select commit
Hold shift + click to select a range
d4dbd3b
Added user favorites actions
14909dd
Package json updates
ad10cc0
Add favorites effect and create favorite entity interface
4e03601
Start favoriting applications on app wall
d5426d5
Fix test helper
85a431d
Fix isFavorite$ observable
592f119
Move favorites fetch into base page
4cd140d
Get faved entity from store
8a205cf
Fix store test helpe
a5b9730
Wire in entity service to hydrate class
cb9abfe
DB Store for User Favorites and go backend
nwmac d7ed9da
Start to wire in the api request to the FE
a79980f
Fix user favorite db creation
nwmac 0bc8ada
Save favorites to BE
14fa2a8
Fetch all favorites
38d5fd7
Allow user to remove favorite
f911900
Be able to favorite and hydrate organizations
3e1420e
Import tidy up
072ac60
Add favorite icon to meta cards
c6008f9
Add favorite star to application
0d8bcbc
Add favoritre button to CF header
5f0cb37
Ensure endpoint in in fav list if child entity is faved
7b3379f
Add back missinfg class
f39c7c1
Group entities by endpoint
153ef09
Begin work to render favorites on home page
3771f8f
Added card mappers for cf entity types
65cdfbe
Added missing file and ensure that favorite card can values can be ob…
84d6cab
Added faux stats panel to home page
59de898
Fix application summary favoriting
f692f84
Added messaging when favorite could not be fetched
b999e5f
Make CF favorites clickable
884cd9c
Add collapsable entites panel on favorite list
46e1157
Merge branch 'v2-master' into user-favorites
4608fcf
Improve ¸..
2e68e9d
Ensure we can register favorite action generators
1afb246
Move favorite icon on card when menu button is present
230dbfa
Fixed the app card favorite star
a767b91
Add favorite button to all the places
8cbece8
Fix space link on fav card
621fc1c
Add endpoint error bar to home page
1d53fb1
Renamed config mapper
9c37ea2
Add confirmation dialog to not found favorite removal
c196e10
Fix jetstream errors
b626bf5
Fix homepage excpetion when endpoint isn't connected
2d9f3b8
Remove console.log
986f358
Add fetching placeholder
1a98567
Ensure we show message when the user has no favorites
676beeb
Make homepage the redirect page.
8bb5c3a
Fix layout of homepage and favorites list
6185fec
Fix home route
4bd0ce9
Update e2e po and spec
51993d3
Give a better error message when unregistering a favorited endpoint
715d37b
Allow favorite cards to add menu items
94847c0
Fixed semi colon error
9388521
Fixed exception when empty action menu is provided to meta-card
c33c75f
Fixed CC issues
2f7eaaa
Add org status to org card
73bebc4
Fix org favorite on summary page
f3ea75b
Tidy up app module
e4fcdce
Simplify favorite meta card constructor
4eaa76c
CC Issues fixed
734ba62
Merge branch 'v2-master' into user-favorites
1f0c9ff
Added comments to config mapper
54e9a7b
Fixed liniting
9c3a8ea
Fix unit tests
1bb518d
Merge remote-tracking branch 'origin/v2-master' into user-favorites
richard-cox 51e878c
Merge remote-tracking branch 'origin/v2-master' into user-favorites
richard-cox 077c18c
Fixed package-lock.json after merge
richard-cox 8eb0935
Ensure we don't attempt to fetch entities from a disconnected endpoint.
b127cbe
Minor updates
3f323d5
Show good messaging when showing favorites from a disconnected endpoint
fd649de
Remove user favorites when un registering an endpoint
8119983
Remove old debug messgae
43aa8ae
FE Linting
1282675
Fix disconnected message on favorites
668d46e
Ensure we refetch favorites when we un-register an endpoint
d39ba31
Fix endpoints login logout test
214e288
Fix homepage e2e test
2755b33
Merge branch 'v2-master' into user-favorites
680cab1
Fix unregister -> register flow
037533b
Remove navigateTo on home page e2e class
413f794
Merge remote-tracking branch 'origin/v2-master' into user-favorites
richard-cox c31db8d
Merge fixes
richard-cox 8e634f4
Fix e2e test
richard-cox b3518d6
Ensure the cf favorites deploy action adds cf into first dropdown.
d712d22
Removed duplicate listCards
richard-cox 8f4b4b6
Create Favourites table cell, apply to Endpoint & CF App tables
richard-cox 8902b94
Fix lint issue
richard-cox e7c9350
Test fixes, add favourites to space apps table
richard-cox 90025de
Fix tests
richard-cox 051edc1
Fix lint
richard-cox fa376e5
WIP Store entity metadata in favorite
a505f0b
Update typing to cope with new metadata based favorite model
b4616d8
Ensure we correctly store metatdata
2396720
Favorites meta cards can now render correctly again
fb30b8b
Add back in error, empty and fetching state into favorite list
84b89f3
Sync favorites when we notice that metadata is out of sync
6aca8ed
Allow users to unfavorite a favorite from the home page.
72df823
Tidy up favorite mapper config and remove the requirement for lines
dc0dd92
Add filtering and searching to favorites list
f1cc8b3
Fix user favorites migration
e2f1a1b
Add and fix search and filtering to favorites homepage
99beba8
Add favorite groups reducer
a8a4601
Finish favorite group reducer and endpoint favorite metacard fixes
4584b13
Fix hydration
23c3a1d
Wait for fav entities to load before trying to render it.
4214302
Favorite list: Don't render entities list when there is no entities
4342bd1
Add space between favorite filters
7779373
Remove unused file
112c65d
Update is favorite selector to use new groups section of the store
ae94f8a
Remove the need for a pagination section
0bdba9f
Fix styling of empty favorite entity list
9d01060
Fix favorite sync for endpoint entities
78fe412
Ensure we correctly add new favorite to the store
7a2c05a
Fix some english
4c39cd5
Ensure we only show the star favorite for endpoints that can be fav'd
1a809f9
Put the favorite star at the end of table columns
cea44ab
Merge branch 'v2-master' into user-favorites
e500c2f
Ensure we remove ethereal groups correctly
3af1e3b
Fix linting
5db9bbe
Unit test fixes
8ad664d
Add favorite group reducer unit tests
0ada4de
Remove fdescribe
7ce2b8d
Put recent entities into store
de52597
Added links to recently visited panel
59cae6e
Improve presentation of recent entities on homepage
3339776
Sync recents to local storage
6ce826e
Only store 500 recent entities
3a80fd3
Remove favorite star from recent entity and update count modifiers
f888368
Rename propagation directive
cdca99d
Rename prop directive
22380b4
Tidy ups for recent list
a2c13e9
Merge remote-tracking branch 'origin/v2-master' into user-favorites
richard-cox 0febd01
Refactored recents to allow for better syncing
0d8e7aa
Add top and history to recnts list
94453ca
Tidy up recent tabs
c4c2c7c
Ensure we only clean up endpoint we disconnect
67b8c40
Improve store tidy up logic
e80b53f
Sync recents with store
c6fda80
Remove local storage sync
8334645
Lint fixes
87ce81d
Add History icon to top nav
a06edf3
Fix space page header favorite
7c01082
Add history to page header
8eb198a
Add no registered endpoints message to home page
2fed486
Move connect endpoint arrow on endpoints page
7662d23
Fix typing
5760ab6
History -> Recent
2ec0b85
Finally remove outline on favorites card select
a3cb40f
Unit test fixes
bc3a321
Stop paginationResetPagination from added invalid fields
446605e
Merge branch 'v2-master' into user-favorites
c266666
Fixes for echo v3 upgrade
317cf15
E2E: Updated endpoint table data getter
81b4d02
Changes following review
richard-cox 7a9658f
Merge remote-tracking branch 'origin/v2-master' into user-favorites
richard-cox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { IFavoriteMetadata } from './store/types/user-favorites.types'; | ||
|
||
export interface ISpaceFavMetadata extends IFavoriteMetadata { | ||
guid: string; | ||
orgGuid: string; | ||
name: string; | ||
cfGuid: string; | ||
} | ||
|
||
export interface IOrgFavMetadata extends IFavoriteMetadata { | ||
guid: string; | ||
status: string; | ||
name: string; | ||
cfGuid: string; | ||
} | ||
|
||
|
||
export interface IAppFavMetadata extends IFavoriteMetadata { | ||
guid: string; | ||
cfGuid: string; | ||
name: string; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the below are all
registerCf<x>
would they be anything other thancf
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No they wouldn't.