-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for terraform version #846
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request introduce new functionality to handle the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
internal/exec/utils.go (1)
Line range hint
64-72
: Consider adding unit tests for the version command.While the implementation is solid, adding unit tests would help ensure the version command behavior remains correct as the codebase evolves.
Would you like me to help generate unit test cases for the version command implementation?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
internal/exec/terraform.go
(1 hunks)internal/exec/utils.go
(1 hunks)
🔇 Additional comments (3)
internal/exec/terraform.go (1)
64-72
: LGTM! Clean implementation of the version command.
The implementation correctly handles the terraform version command by executing it directly without any additional processing, which is the expected behavior.
internal/exec/utils.go (2)
664-672
: Well-structured handling of the version command.
The logic correctly prevents the help flag from triggering when the version command is used, while maintaining the existing help behavior for other single-argument commands.
674-676
: Good code style improvement.
Adding a line break before the helmfile comment improves readability by separating different logical sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @samtholiya
These changes were released in v1.126.0. |
what
With this fix we would be supporting terraform version
why
We say atmos supports all native terraform commands, yet we do not support atmos terraform version.
current implementation example
references
issue: https://linear.app/cloudposse/issue/DEV-2820/atmos-terraform-version-does-not-work
Summary by CodeRabbit
Summary by CodeRabbit
New Features
version
command to display the current Terraform version.Improvements
clean
subcommand to better handle--everything
and--force
flags.version
command is used.Documentation