Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions.tf #45

Closed
wants to merge 5 commits into from
Closed

Update versions.tf #45

wants to merge 5 commits into from

Conversation

Benbentwo
Copy link
Member

what

  • Fixes issue with field session_timeout_hours that is part of 4.0 Aws Provider

why

  • Bugfix

@Benbentwo Benbentwo requested review from a team as code owners June 16, 2022 17:51
@Benbentwo Benbentwo requested review from jhosteny and RothAndrew June 16, 2022 17:51
@Benbentwo
Copy link
Member Author

/test all

versions.tf Outdated

required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 3.0"
version = "~> 3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally never pin to major versions. We should just fix the upstream issue.

@@ -1,14 +1,14 @@
terraform {
required_version = ">= 0.14"
required_version = ">= 1.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update example versions.tf too

@nitrocode nitrocode added the patch A minor, backward compatible change label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants