Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS Provider v5, TLS provider v4 #74

Merged
merged 8 commits into from
Aug 1, 2023
Merged

Support AWS Provider v5, TLS provider v4 #74

merged 8 commits into from
Aug 1, 2023

Conversation

max-lobur
Copy link
Contributor

@max-lobur max-lobur commented Jun 7, 2023 •
edited by Nuru
Loading

what

why

  • Earlier problems with TLS provider v4 caused earlier versions of this module to reject it, but now we are ready to use it.
  • Maintenance

references

Supercedes these PRs

Issues: closes #79

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 7, 2023
@max-lobur max-lobur requested review from a team as code owners June 7, 2023 16:40
@max-lobur max-lobur requested review from dotCipher and srhopkins June 7, 2023 16:40
@max-lobur
Copy link
Contributor Author

/terratest

1 similar comment
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur added minor New features that do not break anything and removed no-release Do not create a new release (wait for additional code changes) labels Jun 22, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@Nuru Nuru added no-release Do not create a new release (wait for additional code changes) and removed minor New features that do not break anything labels Aug 1, 2023
Nuru
Nuru previously approved these changes Aug 1, 2023
View reviewed changes
@Nuru Nuru added major Breaking changes (or first stable release) and removed no-release Do not create a new release (wait for additional code changes) labels Aug 1, 2023
@Nuru Nuru changed the title Support AWS Provider V5 Support AWS Provider v5, TLS provider v4 Aug 1, 2023
@Nuru
Copy link
Contributor

Nuru commented Aug 1, 2023

/terratest

@Nuru
Copy link
Contributor

Nuru commented Aug 1, 2023

/terratest

@Nuru Nuru self-requested a review August 1, 2023 11:21
@Nuru Nuru merged commit 4fc2f49 into main Aug 1, 2023
@Nuru Nuru deleted the aws_v5 branch August 1, 2023 11:22
@Nuru Nuru mentioned this pull request Aug 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referenced module cloudposse/ssm-tls-self-signed-cert/aws needs version update
2 participants
@max-lobur @Nuru