-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [Bug Report] Mage's Molten Armor reflect damage too high #3685
Comments
We will definitely need more infos on this.
|
it's a dynamic damage result with diffrent euipment , just compare with feel before update, a normal level 70 mage can kill a wild enemy with this aura ,just only hold his positon. and I can not upload a youtub video for some firewall reason , so sorry about this. |
Need to check SP coefficients on the spells. Perhaps this was caused in some way by cmangos/mangos-tbc@61990fb |
Im currently not having an active local server to test this but "feel before update" is never a good source, i also feel my hunter should just oneshot everything but thats not how it works. There is so much math behind spells and how things work.
https://www.wowhead.com/tbc/spell=30482/molten-armor So the question still remains, what formular/spellcoef does this spell use to calculate dmg output. |
i know my description has not a comparable evidence for the debug work, cauze this spell's act normally while player was naked, and can kill same level enemy just with reflect damage when player euipped well. i can not calculate the damage value the character should be , but i also know the damage is not how it works, i'll try to get a compare a value from some other server that with priviouse version. this is a issue , just without good comparable evidence. |
Default coefficient calculation had to be removed. I am aware this will likely cause trouble, however it can probably be mitigated if it becomes an issue by importing 0 values from the previous data and then setting default coeff for everything else. For AP however it will be non issue. |
this cmangos/mangos-tbc@f2798ea is useless for this issue , the problem is still there. should not be closed as complete. |
This time I rechecked. |
nice job! it works! |
* fix ProcSystemArguments constructor arg mismatch * [Quest] rework Missing in Action quest using new systems (cmangos#660) * [Quest] rework Missing in Action quest using new systems * add changes requested in comments * SpawnGroup: Implement CREATURE_GROUP_FORMATION_MIRRORING * Config: Implement config override with env vars (cmangos#502) * Config: Implement config override with env vars Implement overriding of configuration from the .conf file with environment variables. Environment variables keys are autogenerated based on the keys defined in .conf file. Usage example: $ export CM_DATA_DIR=/usr $ CM_WORLD_SERVER_PORT=8080 ./mangosd * Update env var key format and encapsulated env loading logic. The new env key format: Mangosd_Rate_Health Mangosd_DataDir * Add suggestions from code review. * Add missing includes. * Pet: Tryfix double unsummon crash due to visibility Close cmangos/mangos-wotlk#508 Credit @insunaa for the general idea * [Quest] modernize defias brotherhood escort quest Closes cmangos#662 * [Quest] modernize 'Protect the Shipment' escort quest Closes cmangos#663 * Remove gameobject los temp fix for playerbots * G3D: Extend Support for new MacOS Versions (+Apple Silicon) * Pet: Fix compilation for pch on linux * Network: Minor rework of code to make it same as wotlk * Move spell to proper section * G3D: Fix MacOS/Apple Silicon compile * Spell/Unit: Remove now redundant default coeff calculation I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685 * AC: Add ignore los to shirrak inhibit magic aoe * Playerbots: Fix grid loading issue (cmangos#536) - Exxenoz * Spell/Unit: Fix default for coefficient being 0 and fix coeff for npc pets Closes cmangos/issues#3685 again --------- Co-authored-by: cdkr <[email protected]> Co-authored-by: _daanieL <[email protected]> Co-authored-by: killerwife <[email protected]> Co-authored-by: Anton Popovichenko <[email protected]> Co-authored-by: insunaa <[email protected]> Co-authored-by: insunaa <[email protected]>
* fix ProcSystemArguments constructor arg mismatch * [Quest] rework Missing in Action quest using new systems (cmangos#660) * [Quest] rework Missing in Action quest using new systems * add changes requested in comments * SpawnGroup: Implement CREATURE_GROUP_FORMATION_MIRRORING * Config: Implement config override with env vars (cmangos#502) * Config: Implement config override with env vars Implement overriding of configuration from the .conf file with environment variables. Environment variables keys are autogenerated based on the keys defined in .conf file. Usage example: $ export CM_DATA_DIR=/usr $ CM_WORLD_SERVER_PORT=8080 ./mangosd * Update env var key format and encapsulated env loading logic. The new env key format: Mangosd_Rate_Health Mangosd_DataDir * Add suggestions from code review. * Add missing includes. * Pet: Tryfix double unsummon crash due to visibility Close cmangos/mangos-wotlk#508 Credit @insunaa for the general idea * [Quest] modernize defias brotherhood escort quest Closes cmangos#662 * [Quest] modernize 'Protect the Shipment' escort quest Closes cmangos#663 * Remove gameobject los temp fix for playerbots * G3D: Extend Support for new MacOS Versions (+Apple Silicon) * Pet: Fix compilation for pch on linux * Network: Minor rework of code to make it same as wotlk * Move spell to proper section * G3D: Fix MacOS/Apple Silicon compile * Spell/Unit: Remove now redundant default coeff calculation I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685 * AC: Add ignore los to shirrak inhibit magic aoe * Playerbots: Fix grid loading issue (cmangos#536) - Exxenoz * Spell/Unit: Fix default for coefficient being 0 and fix coeff for npc pets Closes cmangos/issues#3685 again * Playerbots: Handle spell item requirements by the bot system --------- Co-authored-by: cdkr <[email protected]> Co-authored-by: _daanieL <[email protected]> Co-authored-by: killerwife <[email protected]> Co-authored-by: Anton Popovichenko <[email protected]> Co-authored-by: insunaa <[email protected]> Co-authored-by: insunaa <[email protected]>
I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685
I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685
Bug Details
as title, Mage's Molten Armor reflect damage too high, at least 2-3 times more than it should be
Steps to Reproduce
1.get a mage with Molten Armor
2.cast Molten Armor as aura
3.just melee with any enemy
4.watch the relection damage value , far higher than it should be
Expected behavior
No response
Suggested Workaround
No response
Crash Log
No response
Core SHA1 Commit Hash
6d1e246e16bcc738eec816c9bc54442a976bc63c
Database SHA1 Commit Hash
e0a8f15b1daf01aea1e855fd1788ac3390d0e061
Operating System
ubuntu22
Client Version
2.4.3 (The Burning Crusade)
The text was updated successfully, but these errors were encountered: