[Quest] rework Missing in Action quest using new systems #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerwife
reviewed
Feb 10, 2024
src/game/AI/ScriptDevAI/scripts/eastern_kingdoms/redridge_mountains.cpp
Outdated
Show resolved
Hide resolved
killerwife
reviewed
Feb 10, 2024
src/game/AI/ScriptDevAI/scripts/eastern_kingdoms/redridge_mountains.cpp
Outdated
Show resolved
Hide resolved
killerwife
reviewed
Feb 10, 2024
src/game/AI/ScriptDevAI/scripts/eastern_kingdoms/redridge_mountains.cpp
Outdated
Show resolved
Hide resolved
davidonete
pushed a commit
to davidonete/mangos-tbc
that referenced
this pull request
Mar 25, 2024
* [Quest] rework Missing in Action quest using new systems * add changes requested in comments
davidonete
added a commit
to davidonete/mangos-tbc
that referenced
this pull request
Apr 3, 2024
* fix ProcSystemArguments constructor arg mismatch * [Quest] rework Missing in Action quest using new systems (cmangos#660) * [Quest] rework Missing in Action quest using new systems * add changes requested in comments * SpawnGroup: Implement CREATURE_GROUP_FORMATION_MIRRORING * Config: Implement config override with env vars (cmangos#502) * Config: Implement config override with env vars Implement overriding of configuration from the .conf file with environment variables. Environment variables keys are autogenerated based on the keys defined in .conf file. Usage example: $ export CM_DATA_DIR=/usr $ CM_WORLD_SERVER_PORT=8080 ./mangosd * Update env var key format and encapsulated env loading logic. The new env key format: Mangosd_Rate_Health Mangosd_DataDir * Add suggestions from code review. * Add missing includes. * Pet: Tryfix double unsummon crash due to visibility Close cmangos/mangos-wotlk#508 Credit @insunaa for the general idea * [Quest] modernize defias brotherhood escort quest Closes cmangos#662 * [Quest] modernize 'Protect the Shipment' escort quest Closes cmangos#663 * Remove gameobject los temp fix for playerbots * G3D: Extend Support for new MacOS Versions (+Apple Silicon) * Pet: Fix compilation for pch on linux * Network: Minor rework of code to make it same as wotlk * Move spell to proper section * G3D: Fix MacOS/Apple Silicon compile * Spell/Unit: Remove now redundant default coeff calculation I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685 * AC: Add ignore los to shirrak inhibit magic aoe * Playerbots: Fix grid loading issue (cmangos#536) - Exxenoz * Spell/Unit: Fix default for coefficient being 0 and fix coeff for npc pets Closes cmangos/issues#3685 again --------- Co-authored-by: cdkr <[email protected]> Co-authored-by: _daanieL <[email protected]> Co-authored-by: killerwife <[email protected]> Co-authored-by: Anton Popovichenko <[email protected]> Co-authored-by: insunaa <[email protected]> Co-authored-by: insunaa <[email protected]>
davidonete
added a commit
to davidonete/mangos-tbc
that referenced
this pull request
Apr 4, 2024
* fix ProcSystemArguments constructor arg mismatch * [Quest] rework Missing in Action quest using new systems (cmangos#660) * [Quest] rework Missing in Action quest using new systems * add changes requested in comments * SpawnGroup: Implement CREATURE_GROUP_FORMATION_MIRRORING * Config: Implement config override with env vars (cmangos#502) * Config: Implement config override with env vars Implement overriding of configuration from the .conf file with environment variables. Environment variables keys are autogenerated based on the keys defined in .conf file. Usage example: $ export CM_DATA_DIR=/usr $ CM_WORLD_SERVER_PORT=8080 ./mangosd * Update env var key format and encapsulated env loading logic. The new env key format: Mangosd_Rate_Health Mangosd_DataDir * Add suggestions from code review. * Add missing includes. * Pet: Tryfix double unsummon crash due to visibility Close cmangos/mangos-wotlk#508 Credit @insunaa for the general idea * [Quest] modernize defias brotherhood escort quest Closes cmangos#662 * [Quest] modernize 'Protect the Shipment' escort quest Closes cmangos#663 * Remove gameobject los temp fix for playerbots * G3D: Extend Support for new MacOS Versions (+Apple Silicon) * Pet: Fix compilation for pch on linux * Network: Minor rework of code to make it same as wotlk * Move spell to proper section * G3D: Fix MacOS/Apple Silicon compile * Spell/Unit: Remove now redundant default coeff calculation I am expecting trouble, but we need to threat 0 as 0 Closes cmangos/issues#3685 * AC: Add ignore los to shirrak inhibit magic aoe * Playerbots: Fix grid loading issue (cmangos#536) - Exxenoz * Spell/Unit: Fix default for coefficient being 0 and fix coeff for npc pets Closes cmangos/issues#3685 again * Playerbots: Handle spell item requirements by the bot system --------- Co-authored-by: cdkr <[email protected]> Co-authored-by: _daanieL <[email protected]> Co-authored-by: killerwife <[email protected]> Co-authored-by: Anton Popovichenko <[email protected]> Co-authored-by: insunaa <[email protected]> Co-authored-by: insunaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This will remove old code from script_text and script_movement and use waypoint_path, broadcast_text and creature_spell_list.
Proof
Issues
How2Test
Todo / Checklist