Draft PR for GCT PF clusters emulator #1075
Conversation
Add DEBUG versions of the plugins for the previous emulator with modified code for finding region boundaries (replacing in-line computation which mis-calculated region boundaries in negative eta cards), verbose print-out statements, and a modified output which writes the raw isolation sum IN PLACE of the HoE calculation. Note that the cmsRun config file also uses an old sample which should be updated.
Add DEBUG versions of the plugins for the new firmware-based emulator, with verbose print-out statements, and a modified output which writes the raw isolation sum IN PLACE of the HoE output value. Note that the cmsRun config file also uses an old sample which should be updated.
…line with cms-merge-topic
…with cms-merge-topic
pallabidas
changed the title
pallabidas
changed the title
aloeliger
added
Phase-2
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 9 files that did not meet formatting requirements:
Please run |
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.h
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.h
Outdated
Show resolved
Hide resolved
|
@pallabidas Are we ready to look at a final draft of this emulator? Have you pulled in @skkwan's recent changes? |
|
I am not aware if @skkwan has made the changes, will make the final PR once she does. |
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no files with code check issues! |
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 9 files that did not meet formatting requirements:
Please run |
|
@pallabidas The script is still finding code formatting errors. Could you please fix those? |
|
Will open new PR including updated #1069 |
PR description:
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Before submitting your pull requests, make sure you followed this checklist: