-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emulator for Phase-2 Calo PF clusters using GCT firmware #1095
emulator for Phase-2 Calo PF clusters using GCT firmware #1095
Conversation
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no files with code format issues!
|
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
0130039
to
1075721
Compare
hi @aloeliger the branch is updated to work on the latest checkout instructions for phase2-l1t-integration-1252patch1 , please check |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 2 files that did not meet formatting requirements:
Please run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the formatting.
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloPFClusterEmulator.cc
Outdated
Show resolved
Hide resolved
51df2c5
to
bbfb762
Compare
@epalencia I think this can be moved over to the main CMSSW branch to keep it moving, unless you have any further review here. @pallabidas could you open a PR for this material to the main CMSSW fork? |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 1 files that did not meet formatting requirements:
Please run
|
@pallabidas , is this PR in sync with the corresponding one in master, cms-sw#42424? |
hi @epalencia these are two different branches, the one merged to master has more edits. Do you want me to apply those changes in this branch? |
@pallabidas If possible, we would like to try to keep this as in-synch with the actual CMSSW as possible. |
@epalencia @aloeliger done, please check. |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. Attempts to compile this PR succeeded!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found no issues with the code checks!
I found no issues with the headers!
|
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation. I found 1 files that did not meet formatting requirements:
Please run
|
Tagged as |
PR description:
PR validation:
has passed code checks in draft PR #1075 and validation plots look ok for the collections created.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
not a backport