Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Get latest DD4hep v1-25 commit #8554

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

smuzaffar
Copy link
Contributor

Fixes GCC12 + ROOT 6.28 builds

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33249/summary.html
COMMIT: f92eb1a
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8554/33249/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33249/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33249/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 100 lines from the logs
  • Reco comparison results: 71 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 268
  • DQMHistoTests: Total nulls: 16
  • DQMHistoTests: Total successes: 3195756
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.6559999999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 12434.0,... ): 0.492 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 312.0 ): 0.164 KiB L1T/L1TStage2uGT
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_13_2_ROOT6_X

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33259/summary.html
COMMIT: f92eb1a
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8554/33259/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197958
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197936
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@cms-sw/simulation-l2 any objections on updating dd4hep to latest tag v1.25. Note that this contains a fix which is needed for GCC12/ROOT 6.28

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33258/summary.html
COMMIT: f92eb1a
CMSSW: CMSSW_13_2_ROOT6_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8554/33258/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197958
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197929
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_13_2_X/master to IB/CMSSW_13_2_X/g4 June 21, 2023 09:16
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33286/summary.html
COMMIT: f92eb1a
CMSSW: CMSSW_13_2_GEANT4_X_2023-06-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8554/33286/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33286/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33286/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_GEANT4_X_2023-06-20-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"


@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#42020

@smuzaffar
Copy link
Contributor Author

abort

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmssw#42020 for CMSSW_13_2_GEANT4_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33306/summary.html
COMMIT: f92eb1a
CMSSW: CMSSW_13_2_GEANT4_X_2023-06-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8554/33306/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33306/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29ceed/33306/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 57 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 68918 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197894
  • DQMHistoTests: Total failures: 317128
  • DQMHistoTests: Total nulls: 260
  • DQMHistoTests: Total successes: 2880484
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1203.1080000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 1.183 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12434.0,... ): 596.989 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): 0.064 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 1.150 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.733 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 4.883 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants